Inject service in symfony2 Controller

Question

How can I inject a service (the service that I created) into my Controller? A setter injection would do.

<?php
namespace MyNamespace;

use Symfony\Bundle\FrameworkBundle\Controller\Controller;

class MyController extends Controller
{
    public function setMyService(MyService $myService)
    {
        $this->myService = $myService;
    }

    public function indexAction()
    {
        //Here I cannot access $this->myService;
        //Because the setter is not called magically!
    }
}

And my route settings :

// Resources/routing.yml
myController_index:
    pattern:  /test
    defaults: { _controller: "FooBarBundle:MyController:index" }

I'm setting the service in another bundle :

// Resources/services.yml 
parameters:
   my.service.class: Path\To\My\Service

services:
    my_service:
        class: %my.service.class%

When the route is resolved, the service is not injected ( I know it shouldn't ). I suppose somewhere in a yml file, I have to set:

    calls:
        - [setMyService, [@my_service]]

I am not using this Controller as a service, it's a regular Controller that serves a Request.

Edit: At this point in time, I am getting the service with $this->container->get('my_service'); But I need to inject it.

Answer 1

If you want to inject services into your controllers, you have to define controllers as services.

You could also take a look at JMSDiExtraBundle's special handling of controllers — if that solves your problem. But since I define my controllers as services, I haven't tried that.

Answer 2

When using the JMSDiExtraBundle you DON'T have to define your controller as a service (unlike @elnur said) and the code would be:

<?php

namespace MyNamespace;

use JMS\DiExtraBundle\Annotation as DI;
use Path\To\My\Service;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;

class MyController extends Controller
{
    /**
     * @var $myService Service
     *
     * @DI\Inject("my_service")
     */
    protected $myService;

    public function indexAction()
    {
        // $this->myService->method();
    }
}

I find this approach very nice because you avoid writing a __construct() method.