Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Initializing a static field vs. returning a value in static property get?

A) In the following code, will the method DataTools.LoadSearchList() only be called once, or every time the property is being accessed?

public static IEnumerable<string> SearchWordList {     get     {         return DataTools.LoadSearchList();     } } 

B) Is there any difference to this?

public static IEnumerable<string> SearchWordList = DataTools.LoadSearchList(); 
like image 780
magnattic Avatar asked Mar 18 '11 15:03

magnattic


Video Answer


2 Answers

In your first example, LoadSearchList() will be called each time the property is accessed.

In the second, LoadSearchList() will only be called once (but it will be called whether you use it or not since it is now a field rather than a property).

A better option might be:

private static IEnumerable<string> _searchWordList;  public static IEnumerable<string> SearchWordList {     get      {          return _searchWordList ??              ( _searchWordList = DataTools.LoadSearchList());      } } 

Or if you're using .NET 4.0 and want something thread-safe you can use Lazy<T>, as Jon Skeet mentioned (I think the syntax should be correct, but don't hold me to it):

private static Lazy<IEnumerable<string>> _searchWordList =     new Lazy<IEnumerable<string>>(() => DataTools.LoadSearchList());  public static IEnumerable<string> SearchWordList {     get { return _searchWordList.Value; } } 
like image 144
Justin Niessner Avatar answered Oct 14 '22 12:10

Justin Niessner


In the first case the method will be called every time the property is accessed. When it's set as a field, it will be run exactly once - when the type it initialized - whether or not it's ever accessed.

If you want a lazily-initialized value, I'd recommend Lazy<T> from .NET 4.

like image 28
Jon Skeet Avatar answered Oct 14 '22 13:10

Jon Skeet