I'm trying to include a simple javascript to Google Sites but I get nothing when pressing the button. I put the code inside an HTML Box. The code works perfectly when tested locally. Here is my code:
<script>
function calcul(){
x = parseFloat(document.getElementById("value1").value);
y = parseFloat(document.getElementById("value2").value);
document.getElementById("answer").innerHTML=x+y;
}
</script>
<form action="" id="nothing">
<input type="text" id="value1">
<input type="text" id="value2">
<input type="button" value="Calculate" id="but" onclick="calcul()" />
<p id="answer"></p>
Is there something I forgot to make it work?
Google sites now allow one to embed Javascript snippets into a site; thereby providing some interesting new capabilities with websites built with Google sites.
You can embed CSS, HTML, or JavaScript code directly into your Site. Under the Insert tab to the right, select Embed. Next, select the Embed code tab and paste the code into the textbox. Finally, click Next and then click Insert.
Go to the Sites page that will contain the new gadget. Open the page for editing. Select Insert > More gadgets. Search for the gadget, select it from the categories on the left, or click Add gadget by URL and paste in the URL to your .
Add an HTML Box to classic Google Sites Navigate to the page where you want to add the HTML, CSS or JavaScript. Use the Insert menu, then HTML Box. Once the Insert HTML Box editor appears add the code you want to use.
Google Sites changes your entire script. You have to be a bit more careful writing JavaScript.
Adding var
in front of every variable will fix your problem:
<script>
function calcul(){
var x = parseFloat(document.getElementById("value1").value);
var y = parseFloat(document.getElementById("value2").value);
document.getElementById("answer").innerHTML=x+y;
}
</script>
<form action="" id="nothing">
<input type="text" id="value1">
<input type="text" id="value2">
<input type="button" value="Calculate" id="but" onclick="calcul()" />
</form>
<p id="answer"></p>
This will work ;-)
Google Sites will filter out operations it considers unsafe. Some details here, but was unable to find official documentation with quick search.
As another answer mentions, your variables need var
declarations. This is required because without this, the variables will become global to the window, and potentially could be used to escape whatever sandbox Google is putting around the sites javascript support, potentially causing security concerns.
So to fix:
var x = parseFloat(document.getElementById("value1").value);
var y = parseFloat(document.getElementById("value2").value);
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With