In MVC architecture lets consider django:
I have a method to calculate best employee of the year (1000 lines of code with a complex logic), where should I define it and who will call it?
Thanks
From the Django docs
Adding extra Manager methods is the preferred way to add "table-level" functionality to your models.
year_employee.py
)Lets say you have a model Employee
, so, you should create class for managing employees:
class EmployeeManager(models.Manager)
def of_the_year(self):
from year_employee import my_calc_func
return my_calc_func()
Then add this manager to your model
class Employee(models.Model):
[...]
objects = EmployeeManager()
After that you could simply do this:
chosen_employee = Employee.objects.of_the_year()
As for django, the best place to put business logic is inside models. The view should be clean from business logic and should only be used to get the data to be displayed/presented on template or in other words let the view be used for view logic only.
From django FAQ:
In our interpretation of MVC, the “view” describes the data that gets presented to the user. It’s not necessarily how the data looks, but which data is presented. The view describes which data you see, not how you see it. It’s a subtle distinction.
By putting your business logic under models, it will lead you to unit test easier because models is not coupled with HTTP methods or processing.
I concur with those who think that such logic should be placed within the models.py files. However, something as big as what you have, with over 1k lines of code, would start to clutter the models.py files [for me]. I would be inclined to move such code in a separate file within a given application. No harm in doing that.
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With