Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Importing two functions with same name using roxygen2

I'm a maintainer of a CRAN package and get the following messages when loading:

* checking whether package ‘qdap’ can be installed ... [10s/10s] WARNING Found the following significant warnings:   Warning: replacing previous import ‘annotate’ when loading ‘NLP’   Warning: replacing previous import ‘rescale’ when loading ‘scales’ 

Because I use the plotrix and scales packages as well as the NLP and ggplot packages. They have the functions rescale and annotate in common. This results in a significant warning with the latest CRAN check. So I decide to "fix" it.

I made the description something like this:

Package: qdap Type: Package Title: Bridging the gap between qualitative data and quantitative analysis Version: 1.0.0 Date: 2013-06-26 Author: Tyler Rinker Maintainer: Tyler Rinker <[email protected]> Depends:     R (>= 3.0.0),     ggplot2 (>= 0.9.3.1),     gdata,     grid, Imports:     NLP,     openNLP,     plotrix,     scales, LazyData: TRUE Description: Stuff License: GPL-2 

And added this to some .R files:

#' @import ggplot2 gridExtra RColorBrewer #' @importFrom scales alpha 

But this results in another warning:

* installing *source* package 'qdap' ... ** R ** data *** moving datasets to lazyload DB ** inst ** preparing package for lazy loading Warning: replacing previous import 'rescale' when loading 'scales' Warning: replacing previous import 'annotate' when loading 'NLP' Warning: replacing previous import 'alpha' when loading 'scales' 

How do I use roxygen2's importFrom tag correctly?

I have read: https://github.com/hadley/devtools/wiki/Namespaces

But I learn best from an example where someone had to do this. I'm unsure of how to format the DESCRIPTION file correctly as well as the use of roxygen2 tags to avoid:

* checking whether package ‘qdap’ can be installed ... [10s/10s] WARNING Found the following significant warnings:   Warning: replacing previous import ‘annotate’ when loading ‘NLP’   Warning: replacing previous import ‘rescale’ when loading ‘scales’ 

Here is the qdap GitHub Repo

like image 372
Tyler Rinker Avatar asked Aug 20 '13 19:08

Tyler Rinker


2 Answers

The thing to keep in mind is that you cannot have more than one function with the same name in your package's namespace.

Suppose there are two packages, pkgA and pkgB, that both export a function called foo. If you create a package, pkgC, that has import(pkgA) and import(pkgB) in the NAMESPACE. Now, when you call library(pkgC) you'll get a warning:

replacing previous import 'foo' when loading 'pkgB'.  

Now, suppose someone creates another package, pkgD, that has this in the NAMESPACE file:

import(pkgA) import(pkgB) import(pkgC) 

Then, library(pkgD) will give 2 warnings:

1: replacing previous import ‘foo’ when loading ‘pkgB’  2: replacing previous import ‘foo’ when loading ‘pkgB’  

If everyone adopts the practice of importing entire namespaces, then 30 years from now, there will be a lot of these warnings.

Instead, since you can only have a single "foo" in your package, you should explicitly import the "foo" (and other functions) that you want your package to use. In the above example, the NAMESPACE for pkgD should be

importFrom(pkgB,foo) 

If you actually need to use the two functions with the same name from two different packages, one hack you can perform is to import other functions from each package to ensure the packages are installed and their namespaces are loaded, but then refer to the functions you need using :: notation by placing this in your NAMESPACE:

importFrom(pkgA,foo) importFrom(pkgB,bar) 

and then calling functions pkgA::abc() and pkgB::abc() in your code.

like image 181
GSee Avatar answered Oct 06 '22 13:10

GSee


Most likely no longer of use to you but maybe to others: the answer to your question can be found in the website you mention, in particular, here (quoting from source): "No matter how many times you use @importFrom foo bar".

So the correct use of roxygen2's tag @importFrom is: @importFrom package_name function_name. No commas, parenthesis, nothing, just the two names separated by a space (possibly applicable to more than 1 function, in the obvious way).

I have tried this myself just now when generating the documentation for the new version of one of my packages, so it should work.

I hope it helps.

like image 41
Albert Dorador Avatar answered Oct 06 '22 13:10

Albert Dorador