Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Implementing custom IComparer with string

Tags:

c#

icomparer

I have a collection of strings in c#, for example;

var example = new string[]{"c", "b", "a", "d"};

I then with to sort this, but my IComparer method is not working, and looping infinitely by the seems of things.

Basically I need "b" to come first, followed by "c", then I dont care about the order of any of the others.

Is this possible using IComparer<string> and the Compare(string x, string y) method?

Edit: Code

    public int Compare(string x, string y)
    {
        var sOrder = new string[] { "b", "c" };
        int index_x = -1;
        int index_y = -1;

        for (int i = 0; i < sOrder.Length;i++)
        {
            if (sOrder[i] == x)
                index_x = i;
            else if (sOrder[i] == y)
                index_y = i;
        }

        if (index_x >= 0 && index_y >= 0)
        {
            if (index_x < index_y)
            {
                return -1;
            }
            else
                return 1;
        }
        return 0;
    }
like image 736
maxp Avatar asked Jan 23 '12 17:01

maxp


2 Answers

This should do what you want:

var example = new string[]{"c", "a", "d", "b"};
var comparer = new CustomStringComparer(StringComparer.CurrentCulture);
Array.Sort(example, comparer);

...

class CustomStringComparer : IComparer<string>
{
    private readonly IComparer<string> _baseComparer;
    public CustomStringComparer(IComparer<string> baseComparer)
    {
        _baseComparer = baseComparer;
    }

    public int Compare(string x, string y)
    {
        if (_baseComparer.Compare(x, y) == 0)
            return 0;

        // "b" comes before everything else
        if (_baseComparer.Compare(x, "b") == 0)
            return -1;
        if (_baseComparer.Compare(y, "b") == 0)
            return 1;

        // "c" comes next
        if (_baseComparer.Compare(x, "c") == 0)
            return -1;
        if (_baseComparer.Compare(y, "c") == 0)
            return 1;

        return _baseComparer.Compare(x, y);
    }
}
like image 174
Thomas Levesque Avatar answered Sep 27 '22 23:09

Thomas Levesque


A simple way is to substitute integers for the strings.

class MyComparer : IComparer<string>
{
    public override int Compare(string x, string y)
    {
        int ix = x == "b" ? 0 : x == "c" ? 1 : 2;
        int iy = y == "b" ? 0 : y == "c" ? 1 : 2;
        return ix.CompareTo(iy);
    }
}

var example = new List<string> { "c", "b", "a", "d", "foo", "", "1", "e"};
example.Sort(new MyComparer());
foreach (var s in example)
    Console.WriteLine(s);

Output:

b
c

1
e
a
d
foo

Note that this isn't a stable sort. If you need a stable sort, there's a little more work involved.

like image 44
Igby Largeman Avatar answered Sep 27 '22 21:09

Igby Largeman