Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

How to view line comments in GitHub?

I spent all morning in GitHub reviewing a pull request, writing detailed comments on many lines in the Diff view on the pull-request page.

I individually saved every line-by-line comment, and they all appeared in their correct places. I left the pull-request page, and when I returned to it, all my line-by-line comments were gone!

I have no idea why they disappeared, where they went, whether other users can see them and I can't, what any of this means, and whether I can trust myself going forward using GitHub, or whether I just have to go back to the telephone and fax for remote collaboration!

I did some web searches such as "how to view line comments in GitHub" for info about this, but could not find anything to relieve my panic. I will be grateful for advice and clues.

like image 830
Reb.Cabin Avatar asked Apr 20 '12 14:04

Reb.Cabin


People also ask

How do I see comments on GitHub?

You can view all of the comments made in a single pull request review. You can find a pull request where you or a team you're a member of is requested for review with the search qualifier review-requested:[USERNAME] or team-review-requested:[TEAMNAME] .

Can people read GitHub comments?

Anyone with read access to a repository can view a comment's edit history. Navigate to the comment you'd like to view the edit history for. At the top of the comment, click edited to open the edit history.

How do I extract code review comments from GitHub?

You can click on the date in the header of the comment to get a URL to the comment. It will give you specific comment URL in address bar. You can copy and share the link with your colleagues to address those.

How do I select lines in GitHub?

To select a multi-line code block, you can either: click and hold to the right of a line number, drag and then release the mouse when you've reached the last line of the desired selection; or.


2 Answers

This is top result for "Can't view github comments" in google.

If you're here because you've left comments, and can see your own comments, but others cannnot, then check for a yellow pending label on your comments. Others cannot see your comment until you've completed the review process and selected whether you want to request changes. Once you click through a full review, then others will see your comments.

Note: I'm answering a slightly different question than the O.P., but I have a feeling that lots of other devs with this issue are hitting this stackoverflow question. I'm just hoping to help them. I myself had this issue and couldn't find a more relevant answer than this thread. :)

like image 128
lance.dolan Avatar answered Oct 08 '22 05:10

lance.dolan


The line-comments depend on the commit that were made on.

If the person that made the pull request rebased that commit then you're not looking at what you were previously looking. It's a different commit, thus there are no comments.

Look on the 'Your Actions' tab and find a line in the actions' history were you commented on that commit, click that commit and you'll see the comments are still there.
If the commit was rebased, you wont find that commit were it used to be (some branch) and not on any repo probably (if it's not on another branch). It is just cached by git and github, until the garbage collector kicks in.

like image 32
c00kiemon5ter Avatar answered Oct 08 '22 05:10

c00kiemon5ter