So my question was kind of addressed by this post, but I'm still a little confused. Basically, I'm checking out a repo on GitHub, and I see that there are currently 34 open and 173 closed pull requests. My current understanding is this:
However, a lot of the open requests in this repo are very old, even though they seem to make reasonable changes. This makes me wonder whether my 2nd assumption above is correct. So which is it, do pull requests close when they are merged, or do they remain open? And if they remain open, how can I tell that they were in fact merged, and aren't just in limbo?
Thanks in advance.
Pull requests are closed automatically whenever the maintainer merge the changes through the web interface. If he merged using the command line, it will be closed as soon as he pushes the code back to Github.
So if a PR is still open, it means it is not merged.
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!Donate Us With