how to share global variables across threads in python?

Question

I want to end a loop running in a separate thread using a global variable. but this code does not seem to stop the thread in loop. I expect the program not to print any more '.' after 2 seconds, but it still runs indefinitely.

Am I doing something fundamentally wrong here?

import time
import threading
run = True

def foo():
    while run:
        print '.',

t1 = threading.Thread(target=foo)
t1.run()
time.sleep(2)
run = False
print 'run=False'
while True:
    pass

Answer 1

1. You are executing foo() on the main thread by calling t1.run(). You should call t1.start() instead.

2. You have two definitions of foo() - doesn't matter, but shouldn't be there.

3. You didn't put a sleep() inside the thread loop (in foo()). This is very bad, since it hogs the processor. You should at least put time.sleep(0) (release time slice to other threads) if not make it sleep a little longer.

Here's a working example:

import time
import threading
run = True

def foo():
    while run:
        print '.',
        time.sleep(0)

t1 = threading.Thread(target=foo)
t1.start()
time.sleep(2)
run = False
print 'run=False'
while True:
    pass