How to set the iframe content height in my case?

Question

I am trying to setup the iframe content height through angular

I have something like

<iframe id='iframe' width='100%' height='600px' data-ng-init="init('iframe')" 
 src='http://test.com' />

in my controller

 $scope.init = function(id) {
            console.log($('#'+ id))  -> show my iframe
            var x= $('#'+ id)..contentWindow.document.body.scrollHeight;
            console.log(x) -> gives me undefined

            var y = $('#'+ id)..contentWindow;
            console.log(y) -> give me undefined too 
        }

How do I set the iframe content height through my controller?

Thanks!

Answer 1

Some observations from your code:

1. ng-init is not the equivalient of $(window).on("load", function(){...}), more information about ng-init here: https://docs.angularjs.org/api/ng/directive/ngInit . That's why you are getting undefined for x and y, because when that code is executed the iframe hasn't been loaded yet.

2. In angular is not a good idea to access the DOM from the controller, consider doing those sort of operations in a directive instead.

3. If you are starting with angularjs I would recommend you to try not to use jQuery.

In your case I think that what you want is to define a directive like iframeSetDimentionsOnload and set the height there. I will give you in example in a few minutes.

Your iframeSetDimensionsOnload directive:

yourApp.directive('iframeSetDimensionsOnload', [function(){
return {
    restrict: 'A',
    link: function(scope, element, attrs){
        element.on('load', function(){
            /* Set the dimensions here, 
               I think that you were trying to do something like this: */
               var iFrameHeight = element[0].contentWindow.document.body.scrollHeight + 'px';
               var iFrameWidth = '100%';
               element.css('width', iFrameWidth);
               element.css('height', iFrameHeight);
        })
    }
}}])

Use it like this:

<iframe iframe-set-dimensions-onload src='http://test.com' />