I'm using RTC, my friends submitted their change sets for review, and I'm the reviewer. I can't find their change sets anywhere.
This thread summarizes the process:
- Precondition set: "
Require Work Item Approval
" for "Deliver (client)
" operation for "Everyone
" role.- In the "
Required approvals
", for the "Review
" type, at least one from "Everyone
" role (or "Team Member
" role) is set."
User may overrule
" may also be checked if not all code delivery may require a review process.
There are three developers - D1
, D2
& D3
- all using RTC Eclipse client.
D1
does the code change for filesf1
&f2
in her local workspace and saves them. f1 and f2 appears as unresolved in the pending changes view.D1
checks-in f1 & f2 into a new change set "CS
".
Right clicks on "CS
" and select "Submit for Review
" menu option and associate to a WI (existing or a new one) and select approvers:
D2
as the approver forf1
review (subject field is used to tell what to review) andD3
as approver forf2
review.- The approval/Review process will be in the pending state.
D2
&D3
gets intimation of the review task assigned to them through a query - "Pending approvals for me".D2
opens the WI and in the Links section, double clicks on thef1
in the change set and see the diff in the Change Explorer.
Does the review.
Optionally, adds comment forD1
in the discussion field of theWI
.
Changes theReview
approval state frompending
toapproved
.D3
follows the same process asD2
but rejects because thef3
code change is not acceptable. Changes theReview
approval state frompending
torejected
.D1
gets the review comment via email/feed - becauseD1
is the owner and the subscriber of the WI.D1
fixes the code inf2
based onD3
's review and checks in to the same changeset.D1
addsD3
again for the new review approval in the same WI.D3
gets intimation of the review task assigned to him through a query - "Pending approvals for me
".D3
opens the WI and in the Links section, double clicks on thef2
in the change set and see the diff in the Change Explorer.
Does the review.
Optionally, adds comment forD1
in the discussion field of the WI.
Changes the Review approval state frompending
toapproved
.D1
gets the review comment via email/feed - becauseD1
is the owner and the subscriber of the WI.D1
delivers the changeset (or invokes "Complete
" action on the changeset) because all the approvals in the WI are in approved state.- The complete history of the code review process (rejected ones, approved ones) are in the "
Approvals
" tab.
You can also create a work item query that finds all approvals that are open against you. Mine looks like:
I have that configured as a section in the My Work view, so I know when I have stuff to review.
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With