Menu
I forked GitHub repository and created pull request. Reviewer requested changes from me:
Changes requested
1 review requesting changes by reviewers with write access. Learn more.
I've committed and pushed necessary changes in pull request branch, so they are displaying at pull request page. Now I want ask contributor to continue review my changes.
Is there any button or action for this? Can't find this.
717
To add review comments, click the + icon next to the line number. Type your review comment and then click Start Review. When you are finished adding review comments, from the Side Bar you can choose to either submit the comments, approve the changes, or request changes.
You can resolve a conversation in a pull request if you opened the pull request or if you have write access to the repository where the pull request was opened. To indicate that a conversation on the Files changed tab is complete, click Resolve conversation.
After receiving the pull request, the project maintainer has to decide what to do. If the feature is ready to go, they can simply merge it into main and close the pull request. But, if there are problems with the proposed changes, they can post feedback in the pull request.
2 years and a half years later, (February 2019), do check if the new button "Re-request review" would help.
As illustrated on twitter, if your PR was already reviewed, but now it’s time for round 2: With fresh eyes and fresh code, re-request a review 🔃
Note/caveat: (from "Requesting a pull request review")
Pull request authors can't request reviews unless they are either a repository owner or collaborator with write access to the repository.
As noted in the comments by gertvdijk:
I am a contributor on the project and the owner of the PR.
It does not make sense to me that I need to be a collaborator on the project to request a re-review?Oh, wow, it's by design that PR authors can't use this feature?
Damn, that's very much killing the whole feature.
96
I agree with @prabodhprakash, use the Gear next to "Reviewers" to reselect the reviewer. This changes his status from the red 'x' back to the orange circle.
The problem is the status of the PR remains as "Changes requested". There should be a state after this such as "Changes resolved" or "Needs review" again that is initiated by the requestor, via a button, when s/he is ready for the PR to be looked at again. Otherwise, the PR still looks like it's in the already-reviewed-and-rejected" state.
22
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With
