Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

How to 'reply done' in Gerrit when I address people code review comment

Tags:

gerrit

When using Gerrit review, I want to 'reply done'. So I click 'Reply Done' button. But it is in 'draft' state? How can I submit the 'Reply done'?

like image 499
n179911 Avatar asked May 28 '14 21:05

n179911


People also ask

How do you respond to code review comments?

If a reviewer says that they don't understand something in your code, your first response should be to clarify the code itself. If the code can't be clarified, add a code comment that explains why the code is there. If a comment seems pointless, only then should your response be an explanation in the code review tool.

How do you edit a comment on Gerrit?

No, Gerrit does not support editing comments that have been published. You can edit (or discard) them before publishing, whey they're in the "Draft" status. However, if you desperately need to do it, you must have access to the Gerrit's database.


2 Answers

After you have added your comments to the files you will need to either go and do a 'Review' or 'Add Comment'. This will then also publish your draft comments.

like image 65
uncletall Avatar answered Sep 23 '22 17:09

uncletall


In the change overview, there is a button "Reply.." (on top, right of the commit message). enter image description here

like image 22
StephenKing Avatar answered Sep 24 '22 17:09

StephenKing