i'm using a simple browserWindow like so:
let win = new BrowserWindow({
width: 500,
height: 613,
title: 'My App',
autoHideMenuBar:true,
icon: path.join(__dirname, 'logo.ico'),
resizable:false,
backgroundColor:"#2c2f33",
webPreferences: {
session : session,
webSecurity: false,
}
})
win.on('closed', () => {
win = null
})
// Load a remote URL
win.loadURL('http://192.168.40.189:1337')
session.fromPartition('persist:name');
session.defaultSession.cookies.get({}, (error, cookies) => {
console.log(error, cookies)
})
Whenever i click a link within the browserwindow, a new instance of an electron-browserwindow is created. Is is possible to open links with the default system-browser? (chrome/firefox/vivaldi/etc)
I've read these resources amongst others. But none has yielded any success:
Electron Browser-Window Doc
How do I open a url from on default OS browser?
EDIT:
I've tried this, and it seems like it would be the most likely to work of all the solutions i've found, but it gives me: webContents.on is not a function
.
const {webContents} = require('electron')
var handleRedirect = (e, url) => {
if(url != webContents.getURL()) {
e.preventDefault()
require('electron').shell.openExternal(url)
}
}
webContents.on('will-navigate', handleRedirect)
webContents.on('new-window', handleRedirect)
HTML:
<!DOCTYPE html>
<html lang="en">
<head>
<meta http-equiv="X-UA-Compatible" content="ie=edge">
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.6/css/bootstrap.min.css" integrity="sha384-rwoIResjU2yc3z8GV/NPeZWAv56rSmLldC3R/AZzGRnGxQQKnKkoFVhFQhNUwEyJ" crossorigin="anonymous">
<link rel="stylesheet" href="/css/normalize.css">
<link rel="stylesheet" href="/css/main.css">
</head>
<body>
<div id="loader-wrapper">
<div id="loader"></div>
<div class="loader-section section-left"></div>
<div class="loader-section section-right"></div>
</div>
<div class="chat">
<div class="chat-header clearfix">
<div class="chat-about">
</div>
<i class="fa fa-star"></i>
</div> <!-- end chat-header -->
<div class="chat-history">
<ul id="content"></ul>
</div> <!-- end chat-history -->
<div class="chat-message clearfix">
<input type="text" id="input" class=" message-to-send" tabindex="1" disabled="disabled" placeholder="Enter name" />
</div>
</div>
<div class="chat-num-messages" id="status" style="display: none!important;">Connecting...</div>
<script type="text/javascript" src="//ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js"></script>
<script type="text/javascript">window.jQuery || document.write('<script src="js/vendor/jquery-1.9.1.min.js"><\/script>')</script>
<script type="text/javascript" src="/chat-frontend.js"></script>
<script type="text/javascript" src="jquery.min.js"></script>
<script type="text/javascript" src="js/main.js"></script>
<script type="text/javascript">
const shell = require('electron').shell
const links = document.querySelectorAll('a[href]')
Array.prototype.forEach.call(links, function (link) {
const url = link.getAttribute('href')
if (url.indexOf('http') === 0) {
link.addEventListener('click', function (e) {
e.preventDefault()
shell.openExternal(url)
})
}
})
</script>
<script src="js/vendor/modernizr-2.6.2.min.js"></script>
</body>
</html>
JS-frontend:
// "use strict";
// for better performance - to avoid searching in DOM
const inputElement = document.getElementById('input');
const contentElement = document.getElementById('content');
const statusElement = document.getElementById('status');
var userName = document.getElementById('status');
// my color
var myColor = false;
// my name
var myName = false;
// if mozilla, use built in.
window.WebSocket = window.WebSocket || window.MozWebSocket;
if (!window.WebSocket) {
contentElement.innerHTML = "<p>Sorry, your browser doesn't support websocket.</p>";
inputElement.style = "display: none";
statusElement.style = "display: none";
}
// open connection
const connection = new WebSocket('ws://192.168.40.189:1337');
connection.addEventListener('open', function(e) {
inputElement.removeAttribute('disabled');
statusElement.innerHTML = ' ';
});
connection.addEventListener('error', function (error) {
contentElement.innerHTML = '<p>Sorry, but there\'s some problem with your connection, or the server is down.</p>';
});
connection.addEventListener('message', function (message) {
var json;
try {
json = JSON.parse(message.data);
} catch (e) {
console.log('Invalid JSON: ', message.data);
return;
}
if (json.type === 'color') {
myColor = json.data;
statusElement.innerHTML = myName + '';
statusElement.style.color = myColor;
inputElement.removeAttribute('disabled');
userName = userName;
} else if (json.type === 'history') {
for (var i=0; i < json.data.length; i++) {
var str = json.data[i].text;
var strChanged = str.replace(/https?:\/\/[^ ]+/g, '<span class="linkIsHere">➜</span><a target="_blank" href="$&">[Link]</a>'); // match any word until space
addMessage(json.data[i].author, strChanged, json.data[i].color, new Date(json.data[i].time));
}
} else if(json.type === 'message' && (json.data.author != userName)){
// console.log("author: "+ json.data.author + userName.value);
var str = json.data.text;
var strChanged = str.replace(/https?:\/\/[^ ]+/g, '<span class="linkIsHere">➜</span><a target="_blank" href="$&">[Link]</a>'); // match any word until space
addMessage(json.data.author,strChanged,json.data.color, new Date(json.data.time));
}
else if (json.type === 'message' && json.data.text.length > 60) { //spam protection....
inputElement.value = "Denna checken gjordes speciellt för Christian...";
}
else if (json.type === 'message') {
// standard message.
inputElement.removeAttribute('disabled');
// convert urls to links.
var str = json.data.text;
var strChanged = str.replace(/https?:\/\/[^ ]+/g, '<span class="linkIsHere">➜</span><a target="_blank" href="$&">[Link]</a>'); // match any word until space
addMessageRight(json.data.author, strChanged, json.data.color, new Date(json.data.time));
}
else {
console.log('Hmm..., I\'ve never seen JSON like this:', json);
}
});
//username cookie
function createCookie(name,value,days) {
if (days) {
var date = new Date();
date.setTime(date.getTime()+(days*24*60*60*1000));
var expires = "; expires="+date.toGMTString();
}
else var expires = "";
document.cookie = name+"="+value+expires+"; path=/";
}
function readCookie(name) {
var nameEQ = name + "=";
var ca = document.cookie.split(';');
for(var i=0;i < ca.length;i++) {
var c = ca[i];
while (c.charAt(0)==' ') c = c.substring(1,c.length);
if (c.indexOf(nameEQ) != 0) return nameEQ.match("([^=]*)")[i];
console.log(nameEQ.match("([^=]*)")[i]);
}
return nameEQ.match("([^=]*)");
}
function getCookie(name) {
var nameEQ = name + "=";
var ca = document.cookie.split(';');
for(var i=0;i < ca.length;i++) {
var c = ca[i];
while (c.charAt(0)==' ') c = c.substring(1,c.length);
if (c.indexOf(nameEQ) == 0) return c.substring(nameEQ.length,c.length);
}
return null;
}
function eraseCookie(name) {
createCookie(name,"",-1);
}
/**
* Send message when user presses Enter key
*/
//Cookie Check
if(readCookie(document.cookie) != ""){
var listener = function(){
var myName = ' ';
myName = readCookie(document.cookie);
connection.send(myName);
console.log("HE222EEJ: ")
inputElement.setAttribute('placeholder','Send Message...');
document.removeEventListener('click',listener,true);
};
document.addEventListener('click',listener,true);
// connection.send(msg);
}
if(getCookie(document.cookie) == null){
console.log("HEE333EJ: ")
input.addEventListener('keydown', function(e) {
if (e.keyCode === 13) {
const msg = inputElement.value;
if (!msg) {
return;
}
connection.send(msg);
inputElement.value = '';
inputElement.setAttribute('placeholder','Send Message...');
if(!myName && msg.length > 20){inputElement.value="Sluta nu Christian...";}
if(myName === false){
myName = msg;
userName = myName;
createCookie(userName,userName,7);
}
}
else{
return;
}
});
}
/* om det är connection-problem */
setInterval(function() {
if (connection.readyState !== 1) {
statusElement.innerHTML = 'ERROR';
inputElement.setAttribute('disabled', 'disabled');
inputElement.value = 'Unable to communicate with the WebSocket server.';
}
}, 3000);
/**
* Add message to the chat window
*/
function addMessage(author, message, color, dt) {
contentElement.innerHTML += `<li class="clearfix">
<div class="message-data">
<span class="message-data-name">
<i class="fa fa-circle online"></i>`
+author+
`</span>
<span class="message-data-time">`
+ (dt.getHours() < 10 ? '0'
+ dt.getHours() : dt.getHours()) + ':'
+ (dt.getMinutes() < 10
? '0' + dt.getMinutes() : dt.getMinutes())+
`</span>
</div>`
+`<div class="message my-message" style="background:`+color+`;--my-color-var:`+color+`;">`+message+`
</div>
</li>`;
contentElement.scrollIntoView({block: "end"}); //gjord speciellt för christian.
}
function addMessageRight(author, message, color, dt) {
contentElement.innerHTML += `<li class="clearfix">
<div class="message-data align-right">
<span class="message-data-time">` + (dt.getHours() < 10 ? '0'+ dt.getHours() : dt.getHours()) + ':'+ (dt.getMinutes() < 10? '0' + dt.getMinutes() : dt.getMinutes())+`</span>
<span class="message-data-name">` +author+`</span><i class="fa fa-circle online"></i>
</div>`
+`<div class="message other-message float-right" style="background:`+color+`;--my-other-color-var:`+color+`;">`+message+`
</div>
</li>`;
contentElement.scrollIntoView({block: "end"});
var audio = new Audio('notification.mp3');
audio.play();
}
Thanks
You can do this the way you tried using webContents
's class instance methods instead of static functions
const { app, BrowserWindow, shell } = require('electron')
app.once('ready', () => {
const handleRedirect = (e, url) => {
if (url !== e.sender.getURL()) {
e.preventDefault()
shell.openExternal(url)
}
}
const win = new BrowserWindow()
// Instead bare webContents:
win.webContents.on('will-navigate', handleRedirect)
win.loadURL('http://google.com')
})
Are these links <a>
tags?
If so, this worked for me:
const shell = require('electron').shell
const links = document.querySelectorAll('a[href]')
Array.prototype.forEach.call(links, function (link) {
const url = link.getAttribute('href')
if (url.indexOf('http') === 0) {
link.addEventListener('click', function (e) {
e.preventDefault()
shell.openExternal(url)
})
}
})
It's from the Electron API Demos.
EDIT: For the new links, try something like this (I haven't tested it):
function addMessage(author, message, color, dt) {
contentElement.innerHTML += `<li class="clearfix">
<div class="message-data">
<span class="message-data-name">
<i class="fa fa-circle online"></i>`
+author+
`</span>
<span class="message-data-time">`
+ (dt.getHours() < 10 ? '0'
+ dt.getHours() : dt.getHours()) + ':'
+ (dt.getMinutes() < 10
? '0' + dt.getMinutes() : dt.getMinutes())+
`</span>
</div>`
+`<div class="message my-message" style="background:`+color+`;--my-color-var:`+color+`;">`+message+`
</div>
</li>`;
changeLinkBehaviour();
contentElement.scrollIntoView({block: "end"}); //gjord speciellt för christian.
}
function changeLinkBehaviour(){
var link = contentElement.findElementsByClassName("message my-message")[0].querySelectorAll('a[href]')[0];
//repetition of code I pasted eariler:
const url = link.getAttribute('href')
if (url.indexOf('http') === 0) {
link.addEventListener('click', function (e) {
e.preventDefault()
shell.openExternal(url)
})
}
}
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With