Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

How to make koa ctx.throw() use application/json rather than text/plain

Tags:

javascript

koa

I have made a custom error handler for my koa app which works beautifully (except for one sticking point) - using ctx.throw() means any stacktrace is emitted to the server logs and also any custom error message is sent in the response.

The one problem is that Content-Type header is text/plain but I really need it to be application/json.

app.js:

import Koa from 'koa';
import bodyParser from 'koa-bodyparser';
import logger from 'koa-morgan';

import authentication from './middleware/authentication';
import config from './config';
import errorHandler from './middleware/error-handler';
import notificationsRoutes from './routes/notifications';

const app = new Koa();

app.use(errorHandler);
app.use(bodyParser());
app.use(logger(config.logLevel));
app.use(authentication);
app.use(notificationsRoutes.routes());

export default app;

error-handler.js:

export default async (ctx, next) => {
  return next().catch(({ statusCode, message }) => {
    ctx.throw(statusCode, JSON.stringify({ message }));
  });
};

(I thought (statusCode, JSON.stringify({ message })); might coerce the response into application/json but it doesn't.

I have googled to no avail. Please help!

like image 211
Yorkshireman Avatar asked Oct 03 '18 09:10

Yorkshireman


People also ask

What is CTX in Koa JS?

You may optionally pass a properties object which is merged into the error as-is, useful for decorating machine-friendly errors which are reported to the requester upstream. ctx. throw(401, 'access_denied', { user: user }); Koa uses http-errors to create errors. status should only be passed as the first parameter.

What is CTX state?

The ctx.state is used to set data that are used to pass data between middlewares. For instance, we can use it as follows: const Koa = require('koa'); const app = new Koa();app.use(async (ctx, next) => {

What is middleware KOA?

Koa is a middleware framework that can take two different kinds of functions as middleware: async function. common function.


1 Answers

Managed to modify the error-handler to produce the desired result. Works really well - stack traces are emitted to server logs and the first line of that message becomes the message in the response body. The latter might be considered a downside by some but it depends what you're after.

error-handler.js:

export default async (ctx, next) => {
  return next().catch(err => {
    const { statusCode, message } = err;

    ctx.type = 'json';
    ctx.status = statusCode || 500;
    ctx.body = {
      status: 'error',
      message
    };

    ctx.app.emit('error', err, ctx);
  });
};

Found this and used it for reference: https://github.com/koajs/examples/blob/master/errors/app.js

It's worth mentioning that this custom error - ServerError.js - is used in the app; that's why ctx.status = statusCode || 500 - statusCode is provided by ServerError when used, but for non-custom errors that are thrown, statusCode comes through to error-handler.js as undefined so || 500 is needed.

ServerError.js:

export class ServerError extends Error {
  constructor(statusCode, message) {
    super(message);
    this.statusCode = statusCode;
  }
}

(usage: throw new ServerError(400, 'my informative error message');)

Don't have any catch blocks in any of your middlewares and the error will propagate all the way up to your top errorHandler middleware in app.js (which is what you want to happen).

Custom error handling in koa seems to generate many different opinions but this seems to work well for us for now.

like image 52
Yorkshireman Avatar answered Sep 19 '22 00:09

Yorkshireman