How To Get All The Contiguous Substrings Of A String In Python?

Question

Here is my code, but I want a better solution, how do you think about the problem?

def get_all_substrings(string):   length = len(string)   alist = []   for i in xrange(length):     for j in xrange(i,length):       alist.append(string[i:j + 1])    return alist  print get_all_substring('abcde') 

Answer 1

The only improvement I could think of is, to use list comprehension like this

def get_all_substrings(input_string):   length = len(input_string)   return [input_string[i:j+1] for i in xrange(length) for j in xrange(i,length)]  print get_all_substrings('abcde') 

The timing comparison between, yours and mine

def get_all_substrings(string):   length = len(string)   alist = []   for i in xrange(length):     for j in xrange(i,length):       alist.append(string[i:j + 1])    return alist  def get_all_substrings_1(input_string):   length = len(input_string)   return [input_string[i:j + 1] for i in xrange(length) for j in xrange(i,length)]  from timeit import timeit print timeit("get_all_substrings('abcde')", "from __main__ import get_all_substrings") # 3.33308315277 print timeit("get_all_substrings_1('abcde')", "from __main__ import get_all_substrings_1") # 2.67816185951