How to correctly specify the copy constructor

Question

Assume I have a class Matrix, with a constructor as follows:

Matrix::Matrix(int rows, int cols)
{
    nrows = a; //here nrows is the number of rows for each matrix 
    ncols = b; //here ncols is the number of cols for each matrix
    p = new double [rows*cols];
    for(int i=0;i<rows*cols;i++) 
        { 
            *p++ = 0.0;
        }
}

Suppose I also have a 'copy' constructor as follows:

Matrix::Matrix(const Matrix& mat)
{   p = new double[mat.nrows*mat.ncols];
    for(int i=0;i<mat.nrows*mat.ncols;i++)
        { 
             p[i] = mat.p[i];

        }
}

Now also suppose I have the following lines in my main function:

int main()
    {
        Matrix A(2,2);
        Matrix B(2,2);
        A = Matrix(B); //call overloaded assignment operator, and copy ctor/
     }

Here the '=' operator is overloaded to assign all the elements in B to A. My issue is that once the call to the copy constructor is made, the Matrix A object is a completely new object.

Is there a better way of writing the copy constructor so that if Matrix A already exists then calling A = Matrix(B) results in an error?

Answer 1

Instead of using dynamically allocated arrays, I would recommend using std::vector

class Matrix
{
public:
    Matrix(long rows, long cols);
private:
    long nrows;
    long ncols;
    std::vector<double> p;
}

Then your constructor can be

Matrix::Matrix(long rows, long cols)
: nrows(rows),
  ncols(cols),
  p(rows * cols)
{ }

Along with all of the other benefits of using std::vector over dynamically allocated arrays, you now get a compiler-generated copy constructor, so you don't need to write one.

If you don't want your class to be copyable, delete the copy constructor and copy assignment operator.

class Matrix
{
public:
    Matrix(long rows, long cols);
    Matrix(const Matrix& mat) = delete;
    Matrix& operator=(const Matrix& mat) = delete;
private:
    long nrows;
    long ncols;
    std::vector<double> p;
}