How to cancel or dismiss a custom dialog in its onCreate method?

Question

I have created a custom dialog called MyCustomDialog which extends Dialog. I create and show my custom dialog as follows:

new MyCustomDialog(myContext).show();

I override the Dialog.onCreate(Bundle savedInstanceState) method to do my initialisation. I also check in this method whether a certain condition holds and, if not, I would like to dismiss/cancel my dialog. I have tried calling the cancel() and dismiss() methods in my dialog's onCreate(Bundle savedInstanceState) and onStart() methods but it has no effect.

Anyone know how to cancel or dismiss a dialog (from within the dialog) before it shows?

Answer 1

You should place the logic to determine if the dialog is to be shown outside of the onCreate() method. it does not belong there.

Alternatively, rename your show() method showIfRequired() (or something), and add the conditional show logic there.

I know this doesn't technically answer your question, but what you are trying to do is not the correct design. That's a good thing, as doing in the right way is actually simpler.

Also, as a side note, you should using DialogFragment in favor of Dialog. it's available in the v4 support library.