How To Approve Commits On Github

Question

I have a project on Github and I want to create two distinct teams of contributors.

The first team will be a push/pull self-organising team of people who can make changes at will.

The second team will be people who are new to the project and need more guidance.

I would like to be able to "approve" the changes made by the second team - i.e. peer review them and help them to better understand our standards and the direction of the project.

How do I set the permissions so they can make changes, but those changes need to be approved?

Answer 1

You can add the “trusted” developers as collaborators (Repository Administration → Collaborators); that gives them full read/write access. The rest of the developers can fork the repository and issue a pull request when they want to merge something back. You’ll do a code review in the pull request and if it’s fine, merge it.

Answer 2

with the latest feature launched by github, now it can be done out of the box for any member in team (better to have for all rather than excluding some).

Steps:

1. Configure Protected Branches
2. Disable Merge Button until commit changes are approved by a peer

More Details Here ... Edited the answer as the 1 big issue with forked repo is fixed now