Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

How do you discriminate a cancelled from a retriggered boost deadline_timer

When you call expires_from_now() on a running timer, the timer is cancelled, and a new timer is called. So the associated handler is called. It is easy to discriminate in the handler between a cancelled and an expired timer. Yet, I am wondering, if there is a way to discriminate between a expired and a retriggered timer. In both instances the handler is called with error_code operation_aborted. Or maybe I missing some details.

The code below generates the following output:

20120415 21:32:28079507 Main: Timer1 set to 15 s.    
20120415 21:32:28079798 Main: Timer1 set to 12 s.    
20120415 21:32:28079916 Handler1: Timer 1 was cancelled or retriggered.    
20120415 21:32:40079860 Handler1: expired.

This suggests that the handler is not able to implement actions for a cancelled handler, because retriggering a timer will call the same handler and thereby execute the same actions. Which is probably not the intended behaviour.

#include <boost/asio.hpp> 
#include <boost/thread.hpp> 
#include <boost/date_time/posix_time/posix_time.hpp>
#include <boost/date_time/posix_time/posix_time_io.hpp>
#include <iostream> 

using namespace boost::posix_time;
using namespace std;

void handler1(const boost::system::error_code &ec) 
{ 
    if (ec == boost::asio::error::operation_aborted)
    {
        cout << microsec_clock::local_time() << " Handler1: Timer was cancelled or retriggered." << endl; 
    }
    else
    {
        cout << microsec_clock::local_time() << " Handler1: Timer expired." << endl; 
    }
} 

boost::asio::io_service io_service1; 

void run1() 
{ 
    io_service1.run(); 
} 

int main() 
{ 
    time_facet *facet = new time_facet("%Y%m%d %H:%M:%S%f");
    cout.imbue(locale(cout.getloc(), facet));

    boost::asio::deadline_timer timer1(io_service1, seconds(15)); 
    timer1.async_wait(handler1); 
    cout << microsec_clock::local_time() << " Main: Timer1 set to 15 s." << endl; 
    // now actually run the timer
    boost::thread thread1(run1); 
    timer1.expires_from_now(seconds(12));
    cout << microsec_clock::local_time() << " Main: Timer1 set to 12 s." << endl; 
    // here the timer is running, but we need to reset the deadline
    timer1.async_wait(handler1); 
    thread1.join();   // wait for thread1 to terminate 
} 
like image 420
Michael Hilbert Avatar asked Apr 15 '12 19:04

Michael Hilbert


1 Answers

I'd suggest creating a class to wrapper a deadline_timer using composition. When canceling it, set a flag to remember it was canceled. In the handler, reset the flag. When invoking expires_from_now() don't set the flag.

#include <boost/asio.hpp> 
#include <boost/thread.hpp> 
#include <boost/date_time/posix_time/posix_time.hpp>
#include <boost/date_time/posix_time/posix_time_io.hpp>
#include <iostream> 

class Timer
{
public:
    Timer(
            const std::string& name,
            boost::asio::io_service& io_service
         ) :
        _name( name ),
        _timer( io_service ),
        _cancelled( false )
    {
        _timer.expires_from_now( boost::posix_time::seconds(0) );
        this->wait();
    }

    void wait()
    {
        _timer.async_wait(
                boost::bind(
                    &Timer::handler,
                    this,
                    boost::asio::placeholders::error
                    )
                );
    }

    void cancel() { 
        _cancelled = true;
        _timer.cancel(); 
    }

    void restart() {
        _timer.expires_from_now( boost::posix_time::seconds(5) );
    }

private:
    void handler(
            const boost::system::error_code& error
            )
    {
        if ( !error ) {
            std::cout << _name << " " << __FUNCTION__ << std::endl;
            _timer.expires_from_now( boost::posix_time::seconds(5) );
            this->wait();
        } else if ( error == boost::asio::error::operation_aborted && _cancelled ) {
            _cancelled = false;
            std::cout << _name << " " << __FUNCTION__ << " cancelled" << std::endl;
        } else if ( error == boost::asio::error::operation_aborted ) {
            std::cout  << _name << " " << __FUNCTION__ << " retriggered" << std::endl;
            this->wait();
        } else {
            std::cout << "other error: " << boost::system::system_error(error).what() << std::endl;
        }
    }

private:
    const std::string _name;
    boost::asio::deadline_timer _timer;
    bool _cancelled;
};

int
main()
{
    boost::asio::io_service ios;
    Timer timer1( "timer1", ios );
    Timer timer2( "timer2", ios );

    boost::thread thread(
            boost::bind(
                &boost::asio::io_service::run,
                boost::ref(ios)
                )
            );

    sleep( 3 );
    std::cout << "cancelling" << std::endl;
    timer1.cancel();
    timer2.restart();

    thread.join();
}

sample session

macmini:stackoverflow samm$ ./a.out
timer1 handler
timer2 handler
cancelling
timer1 handler cancelled
timer2 handler retriggered
timer2 handler
^C
macmini:stackoverflow samm$ 
like image 78
Sam Miller Avatar answered Nov 19 '22 04:11

Sam Miller