Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

How do I generate a Friendly URL in C#?

How can I go about generating a Friendly URL in C#? Currently I simple replace spaces with an underscore, but how would I go about generating URL's like Stack Overflow?

For example how can I convert:

How do I generate a Friendly URL in C#?

Into

how-do-i-generate-a-friendly-url-in-C

like image 385
GateKiller Avatar asked Sep 01 '08 11:09

GateKiller


1 Answers

There are several things that could be improved in Jeff's solution, though.

if (String.IsNullOrEmpty(title)) return ""; 

IMHO, not the place to test this. If the function gets passed an empty string, something went seriously wrong anyway. Throw an error or don't react at all.

// remove any leading or trailing spaces left over … muuuch later: // remove trailing dash, if there is one 

Twice the work. Considering that each operation creates a whole new string, this is bad, even if performance is not an issue.

// replace spaces with single dash title = Regex.Replace(title, @"\s+", "-"); // if we end up with multiple dashes, collapse to single dash             title = Regex.Replace(title, @"\-{2,}", "-"); 

Again, basically twice the work: First, use regex to replace multiple spaces at once. Then, use regex again to replace multiple dashes at once. Two expressions to parse, two automata to construct in memory, iterate twice over the string, create two strings: All these operations can be collapsed to a single one.

Off the top of my head, without any testing whatsoever, this would be an equivalent solution:

// make it all lower case title = title.ToLower(); // remove entities title = Regex.Replace(title, @"&\w+;", ""); // remove anything that is not letters, numbers, dash, or space title = Regex.Replace(title, @"[^a-z0-9\-\s]", ""); // replace spaces title = title.Replace(' ', '-'); // collapse dashes title = Regex.Replace(title, @"-{2,}", "-"); // trim excessive dashes at the beginning title = title.TrimStart(new [] {'-'}); // if it's too long, clip it if (title.Length > 80)     title = title.Substring(0, 79); // remove trailing dashes title = title.TrimEnd(new [] {'-'}); return title; 

Notice that this method uses string functions instead of regex functions and char functions instead of string functions whenever possible.

like image 50
Konrad Rudolph Avatar answered Oct 02 '22 17:10

Konrad Rudolph