Menu
I'm reviewing a Github pull request for some new code. As can be seen in the partial screenshot below, some of the files being submitted are binary files that have been intentionally omitted by Github. The message displayed is "Binary file not shown."
I want to comment on the pull request about these files because they are being created in incorrect folders, but Github doesn't appear to have that feature for these files.
Is it possible for me to comment on Github pull requests for binary files not shown? If so, how?
I have tried bumbling around the UI, Googling, searching for this issue on the Github forum and here on SO, but to no avail. Thanks in advance.
723
Hover over the line of code where you'd like to add a comment, and click the blue comment icon. To add a comment on multiple lines, click and drag to select the range of lines, then click the blue comment icon. In the comment field, type your comment.
To edit a pull request, you push new changes into the same branch that was used for the pull request. Github will update everything else automatically.
In the Activity Bar, click the GitHub Pull Request view. This view only appears when you open a pull request in a codespace. To review a specific file, click the Open File icon in the Side Bar. To add review comments, click the + icon next to the line number. Type your review comment and then click Start Review .
For more information, see " Filtering files in a pull request ." Hover over the line of code where you'd like to add a comment, and click the blue comment icon. To add a comment on multiple lines, click and drag to select the range of lines, then click the blue comment icon.
When a Push’ is successful, all your changes are ready to make a pull request. Go back to the original repository and click on Pull Request in the navigation menu, and click on the button ‘New pull request’ Once you click on ‘compare across forks’ you get drop down boxes that will let you compare different repository branches.
It may be the case that you configured your local repo the way that origin points to your fork and upstream – to the original repository (following help.github.com/articles/configuring-a-remote-for-a-fork, for instance). Make sure to change origin to upstream in the mentioned command, if you want to fetch pull request from the original repo.
First, as illustrated in Reviewable/Reviewable issue 135, this is not possible for GitHub itself (even though it is possible for some third-party tools).
Comments are still evolving (see "Multi-line comments"), but nothing involves binaries.
The main workaround remains to leave a comment on the PR itself, (conversation tab) rather than on a non-supported file.
98
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With
