Menu
We would like to use mandatory code reviews on pull requests in GitHub Enterprise 2.10 (using the "Require pull request reviews before merging" feature in the repository protected branch settings).
However, when we enable this feature, Maven release builds fail, since the release plugin tries to push the new SNAPSHOT version to the repository using the credentials of the user that runs the TeamCity release build.
Has anyone come up with an approach that works for this? Our requirements are:
364
To require multiple reviewers for pull requests, go to your repository's settings and select “Branches”. Under “Protected branches”, select the branch you'd like to protect with a multiple reviewers requirement. There you can select the number of reviewers required for each pull request to that branch.
Next to "Branch protection rules", click Add rule. Under "Branch name pattern", type the branch name or pattern you want to protect. Optionally, enable required pull requests. Under "Protect matching branches", select Require a pull request before merging.
No, GitHub doesn't let you restrict who can perform a merge. However, if you want to require a specific group of people to approve a PR before merging, use the CODEOWNERS file and require an approval from a code owner before merging in the branch protection settings.
Using GitHub's settings, you can only block merging by requiring either pull request reviews, status checks to pass, signed commits or linear history as shown under the branch protection settings. Apart from the above, there is no other way currently to block self merging PRs on GitHub.
I found this answer on a related question: https://stackoverflow.com/a/47006088
My impression is that if you leave the "include administrators" checkbox unchecked, then you can use a repository owner with the release plugin. The trade off is you would then rely on discipline from your developers who are repository owners to not skip the review process.
184
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With
