Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

github: code review without pull request?

Using a shared repository model. In short:

  • we want to be able to review code changes
  • but, we don't want pull requests to hold up integration at all

I've used a workflow like this in the past with Code Collaborator, but I don't think it was with Git(?). The point is to allow quicker code integration, while at the same time providing some review of code changes. If the review finds issues, the developer just fixes the issues and integrates, updating the code review in the process. Once the code review is done, there's no "pull" (merge): the code is already merged; the review just gets closed.

like image 283
Hawkeye Parker Avatar asked Oct 27 '17 23:10

Hawkeye Parker


People also ask

How do I review code on GitHub?

To add review comments, click the + icon next to the line number. Type your review comment and then click Start Review. When you are finished adding review comments, from the Side Bar you can choose to either submit the comments, approve the changes, or request changes.

How do I automatically review on GitHub?

At the top of the team page, click Settings. In the left sidebar, click Code review. Select Enable auto assignment. Under "How many team members should be assigned to review?", use the drop-down menu and choose a number of reviewers to be assigned to each pull request.

Is pull request same as code review?

Open a Pull Request – This is a formal request for your commit to be reviewed by another developer. Code Review – A developer agrees to perform a code review on your commit, which may be done formally or informally.

How does GitHub require code review?

To require multiple reviewers for pull requests, go to your repository's settings and select “Branches”. Under “Protected branches”, select the branch you'd like to protect with a multiple reviewers requirement. There you can select the number of reviewers required for each pull request to that branch.


1 Answers

You still can consider Gerrit for your review process.
It even has an "auto-merge during Push" which would allow you to merge immediately, while retaining a spot where to conduct your review.

As commented, this is not the ideal workflow, but the point is: you can configure Gerrit in multiple ways.

like image 193
VonC Avatar answered Sep 20 '22 15:09

VonC