Menu
I'm a Pull Request owner (I have created this Pull Request / branch).
I asked my boss to review my code after I completed working on it and it passed the build tests.
The boss reviewed my code and requested several changes / asked several questions about my code changes.
I have changed the code and answered all the comments however "Changes requested" label still presented for this branch.
What did I miss?
(Sorry for such a simple question, I'm new with GitHub and I could not find answer for this problem in GitHub Helps.
670
Just add a new commit to the branch used in the pull request and push the branch to GitHub. The pull request will automatically be updated with the additional commit.
When someone leaves a review that requests changes, dismissing the review changes it from a review that requests changes to a review comment. This will unblock your pull request, freeing you up to merge it! You can also dismiss an approving review.
The reviewer who requested changes has to either "dismiss" the review or "approve" the change. You might think you addressed everything, but the reviewer might disagree ;-)
It'd be nice if there was a way to differentiate between "<reviewer> requested changes" and "<reviewer> requested changes, and <submitter> updated the PR", but there currently isn't any.
60
Things have changed since the currently accepted answer.
Since februari 2019 you can differentiate a little bit by "re-requesting" a review https://github.blog/changelog/2019-02-21-re-request-review-on-a-pull-request/ . This won't make the "changes requested" label go away, for reasons already explained by Mikeage. However, it will add a "pending reviewer" label making it clear what the current status of the PR is and notify the reviewer that it is their turn again in order to keep the process moving.
31
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With
