Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Generating a random bit - lack of randomness in C rand()

Tags:

c

random

I am using rand() to generate either 0 or 1 (rand() % 2). I am seeding it using the current time (srand(time(NULL))).

After much debugging, I realised that rand() never returns an even (odd) number 16 or more times in a row.

Is this a known issue? Is there a better PRNG that comes with C?

I am running on Windows 7 using Visual Studio 2010.

like image 214
Benjy Kessler Avatar asked Jul 10 '12 16:07

Benjy Kessler


2 Answers

Instead of using rand()%2, try rand()>(RAND_MAX/2). You can only assume rand() to be uniform on the interval [0, RAND_MAX].

Edit: This was suggested by Shahbaz in the comments, which I only noticed after I posted this answer.

Edit: ArjunShankar called me out on my previous wording: "rand() is only specified to be uniform on the interval [0, RAND_MAX]"

From the C99 standard:

The rand function computes a sequence of pseudo-random integers in the range 0 to RAND_MAX.

Technically, uniformity (or equidistributed) is not specified, but is the de-facto standard used for implementations of commonly used PRNG's (e.g. Mersenne Twister). This is to allow a programmer to easily create a custom PRNG with a non-uniform distribution. Without this property, a programmer is forced to implement a custom PRNG from scratch.

like image 176
jxh Avatar answered Sep 30 '22 01:09

jxh


I'd suggest using a better RNG. You're running on Windows so you can use rand_s: It's a Microsoft extension that uses the Windows cryptographic RNG.

like image 25
Aaron Klotz Avatar answered Sep 30 '22 01:09

Aaron Klotz