Find if date is more than another date

Question

I can't work out why this VB.net code is not working..

What I am trying to do is if value1 > value2 then show a messagebox saying expired else show a messagebox saying not expired.

If "4-3-13 10:54:22" > "15-3-13 12:23:30" Then
    MsgBox("Expired")
Else
    MsgBox("Not Expired")
End If

everytime it comes up saying expired even knowing it shouldn't.

When I change it from 15-3-13 12:23:30 to 1-3-13 12:23:30 it still say expired.

If I change my code to be:

If "4-3-13 10:54:22" < "15-3-13 12:23:30" Then
    MsgBox("Not Expired")
Else
    MsgBox("Expired")
End If

It still returns wrong.

How do I make it so that:

DATE1 = 4-3-13 10:54:22

DATE2 = 15-3-13 12:23:30


IF DATE1 > DATE2 THEN
   Expired
else
   Not Expired

Should return 'Not expired'

Anyone able to help.. I can't work it ?

Answer 1

"4-3-13 10:54:22" > "15-3-13 12:23:30" 
'This condition states that you are comaparring strings not date

In order to get the result as you've expected, do like this,

cdate("4-3-13 10:54:22") > cdate("15-3-13 12:23:30")
'Convert the strings into date and then compare it.

CDATE

Answer 2

These date constants will also do as you expect, and won't be subject to the locale when the program is run:

#3/4/2013 10:54:22# > #3/15/2013 12:23:30#

Just remember you need to use US Date Format for the constants.

Answer 3

Try this:

dim date1 as DateTime = DateTime.ParseExact("4-3-13 10:54:22", "MM-dd-yy HH:mm:ss")

dim date2 as DateTime = DateTime.ParseExact("15-3-13 12:23:30", "MM-dd-yy HH:mm:ss")

if date1 > date2 then
MsgBox("Expired")
else
MsgBox("Not Expired")
end if