Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Finalizing a Cursor that has not been deactivated or closed non-fatal error

i'm getting a "Finalizing a Cursor that has not been deactivated or closed" error on this piece of code. The code is used to fill a listview.

Since it's a non-fatal error , there is no crash and all seems to works fine..but i don't like the error.

If i close the cursor at the end of this code..the listview stay's empty. if i close the cursor in onStop , i get the same error.

How do i fix this??

private void updateList() {          DBAdapter db = new DBAdapter(this);          db.open();              //load all waiting alarm              mCursor=db.getTitles("state<2");              setListAdapter(new MyCursorAdapter(this, mCursor));              registerForContextMenu(getListView());              db.close();          }    error :    E/Cursor  ( 2318): Finalizing a Cursor that has not been deactivated  or closed. database = /data/data/xxxxxxxxxxxxxxx.db, table = alerts,  query = SELECT _id, alert_id,  E/Cursor  ( 2318):  android.database.sqlite.DatabaseObjectNotClosedException: Application  did not close the cursor or database  object that was opened here  E/Cursor  ( 2318):      at  android.database.sqlite.SQLiteCursor.<init>(SQLiteCursor.java:210)  E/Cursor  ( 2318):      at  android.database.sqlite.SQLiteDirectCursorDriver.query(SQLiteDirectCursorDr­iver.java:  53)  E/Cursor  ( 2318):      at  android.database.sqlite.SQLiteDatabase.rawQueryWithFactory(SQLiteDatabase.j­ava:  1345)  E/Cursor  ( 2318):      at  android.database.sqlite.SQLiteDatabase.queryWithFactory(SQLiteDatabase.java­:  1229)  ....  ....  
like image 875
arnold Avatar asked Jun 18 '10 08:06

arnold


People also ask

What would be result of not closing cursor?

Not closing a cursor will keep locks active that it holds on the rows where it is positioned.

Why we may have problems if we do not close the cursor?

If you do not close the cursor then you will have issues accessing your data in your database because while the database is open, it is not accessible should something happen like the Activity is paused or otherwise. Specifically, this problem can be alleviated if you let the Activity manage it.


1 Answers

You should not be getting that message if you close the Cursor in onStop() or onDestroy(). Please try that again. Or, call startManagingCursor() after you get the Cursor from your query, and Android will close the Cursor on its own.

like image 67
CommonsWare Avatar answered Sep 23 '22 17:09

CommonsWare