i'm getting a "Finalizing a Cursor that has not been deactivated or closed" error on this piece of code. The code is used to fill a listview.
Since it's a non-fatal error , there is no crash and all seems to works fine..but i don't like the error.
If i close the cursor at the end of this code..the listview stay's empty. if i close the cursor in onStop , i get the same error.
How do i fix this??
private void updateList() { DBAdapter db = new DBAdapter(this); db.open(); //load all waiting alarm mCursor=db.getTitles("state<2"); setListAdapter(new MyCursorAdapter(this, mCursor)); registerForContextMenu(getListView()); db.close(); } error : E/Cursor ( 2318): Finalizing a Cursor that has not been deactivated or closed. database = /data/data/xxxxxxxxxxxxxxx.db, table = alerts, query = SELECT _id, alert_id, E/Cursor ( 2318): android.database.sqlite.DatabaseObjectNotClosedException: Application did not close the cursor or database object that was opened here E/Cursor ( 2318): at android.database.sqlite.SQLiteCursor.<init>(SQLiteCursor.java:210) E/Cursor ( 2318): at android.database.sqlite.SQLiteDirectCursorDriver.query(SQLiteDirectCursorDriver.java: 53) E/Cursor ( 2318): at android.database.sqlite.SQLiteDatabase.rawQueryWithFactory(SQLiteDatabase.java: 1345) E/Cursor ( 2318): at android.database.sqlite.SQLiteDatabase.queryWithFactory(SQLiteDatabase.java: 1229) .... ....
Not closing a cursor will keep locks active that it holds on the rows where it is positioned.
If you do not close the cursor then you will have issues accessing your data in your database because while the database is open, it is not accessible should something happen like the Activity is paused or otherwise. Specifically, this problem can be alleviated if you let the Activity manage it.
You should not be getting that message if you close the Cursor
in onStop()
or onDestroy()
. Please try that again. Or, call startManagingCursor()
after you get the Cursor
from your query, and Android will close the Cursor
on its own.
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With