Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

extension method call another in same extension class - good design?

i ask myself if it is a good design if an extension method uses another in the same extension class.

public class ClassExtensions
{
   public static bool IsNotNull<T>(this T source)
      where T : class
   {
      return !source.IsNull();
   }

   public static bool IsNull<T>(this T source)
      where T : class
   {
      return source == null;
   }
}

EDIT Thanks for the answers. And sorry for the bad sample.

like image 462
Khh Avatar asked Sep 16 '10 18:09

Khh


1 Answers

It's fine. Your example is a little trivial, of course, but consider other situations where a method could provide overloads (using string.Substring as example... pretend method doesn't already exist).

public static class Foo
{
    public static string Substring(this string input, int startingIndex)
    {
         return Foo.Substring(input, startingIndex, input.Length - startingIndex);
         // or return input.Substring(startingIndex, input.Length - startingIndex);
    }

    public static string Substring(this string input, int startingIndex, int length)
    {
         // implementation 
    }
}

Calling overloads obviously allows you to keep your logic centralized as much as possible without repeating yourself. It is true in instance methods, it is true in static methods (including, by extension, extension methods).

like image 168
Anthony Pegram Avatar answered Oct 18 '22 00:10

Anthony Pegram