Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Exploding an array within a foreach loop parameter

foreach(explode(',' $foo) as $bar) { ... }

vs

$test = explode(',' $foo);
foreach($test as $bar) { ... }

In the first example, does it explode the $foo string for each iteration or does PHP keep it in memory exploded in its own temporary variable? From an efficiency point of view, does it make sense to create the extra variable $test or are both pretty much equal?

like image 987
NightHawk Avatar asked May 02 '11 19:05

NightHawk


People also ask

How to explode an array within a foreach loop in PHP?

php - Exploding an array within a foreach loop parameter - Stack Overflow foreach(explode(',' $foo) as $bar) { ... } vs $test = explode(',' $foo); foreach($test as $bar) { ... } In the first example, does it explode the $foo string for each iteration or does PHP keep ... Stack Overflow About Products For Teams

How to loop through an array using foreach method?

Firstly, to loop through an array by using the forEach method, you need a callback function (or anonymous function): The function will be executed for every single element of the array. It must take at least one parameter which represents the elements of an array:

How to read a collection of items using a foreach loop?

C# language provides several techniques to read a collection of items. One of which is foreach loop. The foreach loop provides a simple, clean way to iterate through the elements of an collection or an array of items. One thing we must know that before using foreach loop we must declare the array or the collections in the program.

What are the parameters of the foreach method?

The forEach method passes a callback function for each element of an array together with the following parameters: 1 Current Value (required) - The value of the current array element 2 Index (optional) - The current element's index number 3 Array (optional) - The array object to which the current element belongs More ...


2 Answers

I could make an educated guess, but let's try it out!

I figured there were three main ways to approach this.

  1. explode and assign before entering the loop
  2. explode within the loop, no assignment
  3. string tokenize

My hypotheses:

  1. probably consume more memory due to assignment
  2. probably identical to #1 or #3, not sure which
  3. probably both quicker and much smaller memory footprint

Approach

Here's my test script:

<?php

ini_set('memory_limit', '1024M');

$listStr = 'text';
$listStr .= str_repeat(',text', 9999999);

$timeStart = microtime(true);

/*****
 * {INSERT LOOP HERE}
 */

$timeEnd = microtime(true);
$timeElapsed = $timeEnd - $timeStart;

printf("Memory used: %s kB\n", memory_get_peak_usage()/1024);
printf("Total time: %s s\n", $timeElapsed);

And here are the three versions:

1)

// explode separately 
$arr = explode(',', $listStr);
foreach ($arr as $val) {}

2)

// explode inline-ly 
foreach (explode(',', $listStr) as $val) {}

3)

// tokenize
$tok = strtok($listStr, ',');
while ($tok = strtok(',')) {}

Results

explode() benchmark results

Conclusions

Looks like some assumptions were disproven. Don't you love science? :-)

  • In the big picture, any of these methods is sufficiently fast for a list of "reasonable size" (few hundred or few thousand).
  • If you're iterating over something huge, time difference is relatively minor but memory usage could be different by an order of magnitude!
  • When you explode() inline without pre-assignment, it's a fair bit slower for some reason.
  • Surprisingly, tokenizing is a bit slower than explicitly iterating a declared array. Working on such a small scale, I believe that's due to the call stack overhead of making a function call to strtok() every iteration. More on this below.

In terms of number of function calls, explode()ing really tops tokenizing. O(1) vs O(n)

I added a bonus to the chart where I run method 1) with a function call in the loop. I used strlen($val), thinking it would be a relatively similar execution time. That's subject to debate, but I was only trying to make a general point. (I only ran strlen($val) and ignored its output. I did not assign it to anything, for an assignment would be an additional time-cost.)

// explode separately 
$arr = explode(',', $listStr);
foreach ($arr as $val) {strlen($val);}

As you can see from the results table, it then becomes the slowest method of the three.

Final thought

This is interesting to know, but my suggestion is to do whatever you feel is most readable/maintainable. Only if you're really dealing with a significantly large dataset should you be worried about these micro-optimizations.

like image 89
Wiseguy Avatar answered Oct 04 '22 13:10

Wiseguy


In the first case, PHP explodes it once and keeps it in memory.

The impact of creating a different variable or the other way would be negligible. PHP Interpreter would need to maintain a pointer to a location of next item whether they are user defined or not.

like image 25
Shamim Hafiz - MSFT Avatar answered Oct 04 '22 14:10

Shamim Hafiz - MSFT