Menu
I was wondering what the proper etiquette to contributing on GitHub is?
Should you submit a "New Issue" first and discuss the problem?
Or do you take some initiative, code, then do a "Pull Request" and discuss the code further there?
My concern with creating a "New Issue" first is that if you do a "Pull Request" after, there would be two issues #'s created... seems like a waste.
Thanks!
238
You may choose to close a pull request without merging it into the upstream branch. This can be handy if the changes proposed in the branch are no longer needed, or if another solution has been proposed in another branch.
Particularly in less-established projects where you might have to continue building your work on the pull request you've just created, being blocked by a code review can be frustrating. To me, two times a day is a good interval for when to review.
Close a pull request (console) After the status of a pull request is changed to Closed, it cannot be changed back to Open, but users can still comment on the changes and reply to comments.
If you sent a pull request on a repository where you don't have the rights to close it, you can delete the branch from where the pull request originated. That will cancel the pull request.
The difference is quite clear:
If you make a pull issue first, and then create a pull request, nothing stops you to reference the issue URL in your pull request comment, in order to avoid writing again the context of your patch.
138
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With
