Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Dynamically added script will not execute

I am dynamically adding a script of a github gist. If I added it to the html before the page loads, the script will execute. But If I try to add it to the page after it loads it adds the script to the page but doesn't execute it.

Here is how I am adding it to the page

Html

<div id="results"></div>

Javascript

$('#results').click(function() {
    var script = document.createElement("script");
    script.type = "text/javascript";
    script.src = "https://gist.github.com/1265374.js?file=GetGists.js";
    document.getElementById('results').appendChild(script);
    console.log('script added');
});

Here is the live example

http://jsfiddle.net/guanome/JqB3g/3/

like image 803
FarFigNewton Avatar asked Oct 13 '11 22:10

FarFigNewton


1 Answers

So, the best option I can see is to override (even if just temporarily while the script loads) document.write. It is sort of a work around, but since you don't control the code coming in, I think it may be the best you've got. You also shouldn't be using document.write anytime after the page loads, but just in case, I'd maybe comb through your code.

Here's a fiddle with a working solution. If you wanted to revert document.write after the script loaded, you can always check to see if script.complete is true, otherwise, listen for an onload event, which should allow you to change document.write back. I'm too lazy to code it into the fiddle at the moment, but this would be the code generally:

script.src = "...";
document.getElementById("results").appendChild(script);
if(script.complete) document.write = document._write;
else script.load(function() { 
    // Goes to the end of the run queue so that the script 
    // is guaranteed to run before this code
    setTimeout(function(){document.write = document._write;},0);
});
like image 52
LoveAndCoding Avatar answered Oct 13 '22 19:10

LoveAndCoding