Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

django class-based view - UpdateView - How to access the request user while processing a form?

In a class-base UpdateView in Django, I exclude the user field as it is internal to the system and I won't ask for it. Now what is the proper Django way of passing the user into the form. (How I do it now, is I pass the user into the init of the form and then override the form's save() method. But I bet that there is a proper way of doing this. Something like a hidden field or things of that nature.

# models.py
class Entry(models.Model):
    user = models.ForeignKey(
                User,
                related_name="%(class)s",
                null=False
    )

    name = models.CharField(
                blank=False, 
                max_length=58,
    )

    is_active = models.BooleanField(default=False)

    class Meta:
        ordering = ['name',]

    def __unicode__(self):
        return u'%s' % self.name

# forms.py
class EntryForm(forms.ModelForm):
    class Meta:
        model = Entry
        exclude = ('user',)

# views.py
class UpdateEntry(UpdateView):
    model = Entry
    form_class = EntryForm
    template_name = "entry/entry_update.html"
    success_url = reverse_lazy('entry_update')

    @method_decorator(login_required)
    def dispatch(self, *args, **kwargs):
        return super(UpdateEntry, self).dispatch(*args, **kwargs)

# urls.py
url(r'^entry/edit/(?P<pk>\d+)/$',
    UpdateEntry.as_view(),
    name='entry_update'
),
like image 464
un33k Avatar asked Mar 02 '12 23:03

un33k


3 Answers

Must return an HttpResponse object. The code below works:

class MyUpdateView(UpdateView):
    def form_valid(self, form):
        instance = form.save(commit=False)
        instance.user = self.request.user
        return super(MyUpdateView, self).form_valid(form)
like image 114
David Dehghan Avatar answered Nov 12 '22 07:11

David Dehghan


We can also do like

class MyUpdateView(UpdateView):
    form_class = SomeModelForm

    def form_valid(self, form):
        form.instance.user = self.request.user
        return super(MyUpdateView, self).form_valid(form)
like image 27
anjaneyulubatta505 Avatar answered Nov 12 '22 08:11

anjaneyulubatta505


Hacking around like passing a hidden field doesn't make sense as this truly has nothing to do with the client - this classic "associate with logged in user" problem should definitely be handled on the server side.

I'd put this behavior in the form_valid method.

class MyUpdateView(UpdateView):
    def form_valid(self, form):
        instance = form.save(commit=False)
        instance.user = self.request.user
        super(MyUpdateView, self).save(form)

   # the default implementation of form_valid is...
   # def form_valid(self, form):
   #     self.object = form.save()
   #     return HttpResponseRedirect(self.get_success_url())
like image 7
Yuji 'Tomita' Tomita Avatar answered Nov 12 '22 06:11

Yuji 'Tomita' Tomita