Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Dispose method in web api 2 web service

I am coding an MVC 5 internet application with a web api 2 web service. Do I need a dispose method for the DbContext class in a web service? It is not there as default.

like image 279
user3736648 Avatar asked Jan 12 '15 05:01

user3736648


2 Answers

Actually, System.Web.Http.ApiController already implements IDisposable:

// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved. See License.txt in the  project root for license information.
// ...
public abstract class ApiController : IHttpController, IDisposable
{
// ...
    #region IDisposable

    public void Dispose()
    {
        Dispose(true);
        GC.SuppressFinalize(this);
    }

    protected virtual void Dispose(bool disposing)
    {
    }

    #endregion IDisposable
}

So, if your controller holds a DbContext, do the following:

public class ValuesController : ApiController
{
    private Model1Container _model1 = new Model1Container();

    protected override void Dispose(bool disposing)
    {
        if (disposing)
        {
            if (_model1 != null)
            {
                _model1.Dispose();
            }
        }
        base.Dispose(disposing);
    }
}
like image 90
John Saunders Avatar answered Sep 28 '22 00:09

John Saunders


In Web Api 2, you can register a component for disposal when the request goes out of scope. The method is called "RegisterForDispose" and it's part of the Request. The component being disposed must implement IDisposable.

The best approach is to create your own extension method as below...

       public static T RegisterForDispose<T>(this T toDispose, HttpRequestMessage request) where T : IDisposable
   {
       request.RegisterForDispose(toDispose); //register object for disposal when request is complete
      return toDispose; //return the object
   }

Now (in your api controller) you can register objects you want to dispose when request finalize...

    var myContext = new myDbContext().RegisterForDispose(Request);

Links... https://www.strathweb.com/2015/08/disposing-resources-at-the-end-of-web-api-request/

like image 40
Rich InfiniteLoop Avatar answered Sep 27 '22 23:09

Rich InfiniteLoop