Disabling submit button based on fields added with ng-bind-html

Question

JSFiddle here: http://jsfiddle.net/c6tzj6Lf/4/

I am dynamically creating forms and buttons and want to disable the buttons if the required form inputs are not completed.

HTML:

<div ng-app="choicesApp">
  <ng-form name="choicesForm" ng-controller="ChoicesCtrl">
    <div ng-bind-html="trustCustom()"></div>
    <button ng-repeat="button in buttons" ng-disabled="choicesForm.$invalid">
      {{button.text}}
    </button>
  </ng-form> 
</div> 

JavaScript:

angular.module('choicesApp', ['ngSanitize'])
  .controller('ChoicesCtrl', ['$scope', '$sce', function($scope, $sce) {
    $scope.custom = "Required Input: <input required type='text'>";
    $scope.trustCustom = function() {
      return $sce.trustAsHtml($scope.custom);
    };
    $scope.buttons = [
      {text:'Submit 1'},
      {text:'Submit 2'}];
}]);

choicesForm.$invalid is false and does not change when entering text into the input field.

Solution:

I ended up using the angular-bind-html-compile directive from here: https://github.com/incuna/angular-bind-html-compile

Here is the relevant bit of working code:

<ng-form name="choicesForm">
  <div ng-if="choices" bind-html-compile="choices"></div>
  <button ng-click="submitForm()" ng-disabled="choicesForm.$invalid">
    Submit 
  </button>
</ng-form>

And choices might be a snippit of HTML like this:

<div><strong>What is your sex?</strong></div>
<div>
  <input type="radio" name="gender" ng-model="gender" value="female" required>
  <label for="female"> Female</label><br>
  <input type="radio" name="gender" ng-model="gender" value="male" required>
  <label for="male"> Male</label>
</div>

Answer 1

The main problem is that ngBindHtml doesn't compile the html - it inserts the html as it is. You can even inspect the dynamic input and see that it doesn't have the ngModel's CSS classes (ng-pristine, ng-untouched, etc) which is a major red flag.

In your case, the form simply doesn't know that you've added another input or anything has changed for that matter. Its state ($pristine, $valid, etc) isn't determined by its HTML but by the registered NgModelControllers. These controllers are added automatically when an ngModel is linked.

• For example this <input required type='text'> won't affect the form's validity, even if it's required, since it doesn't have ngModel assigned to it.
• But this <div ng-model="myDiv" required></div> will affect it since it's required and has ngModel assigned to it.

The ngDisabled directive on your buttons works as expected since it depends on the form's $invalid property.

See this fiddle which showcases how ngModel registers its controller. Note that the html containing the dynamic input gets compiled after 750ms just to show how NgModelControllers can be added after FormController has been instantiated.

There are a few solutions in your case:

• use a custom directive to bind and compile html - like this one

• use ngInclude which does compile the html

• use $compile to compile the newly added HTML but this is a bit tricky as you won't know exactly when to perform this action

Answer 2

This is an answer yet imcomplete because i cannot do the code at the moment.

I think your html will be included, not compiled. So the inputs are not bind to angular and are not part of the angular form object.

The only way i see is to use a directive that will compile the passed html and add it to your form. This may be quite tricky though, if you want to go on this way i suggest to edit your question to ask for the said directive.

However i'm not really familiar with $compile so i don't know if it'll work to just add $compile around $sce.trustAsHtml()

Answer 3

You can write a method as ng-disabled does not work with booleans, it works with 'checked' string instead:

So on your controller place a method :

$scope.buttonDisabled = function(invalid){
        return invalid ? "checked" : "";
    };

And on your view use it on angular expression :

<button ng-repeat="button in buttons" ng-disabled="buttonDisabled(choicesForm.$invalid)">

Here is a working fiddle