Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Correct way to close WCF 4 channels effectively

I am using the following ways to close the WCF 4 channels. Is this right way to do it?

using (IService channel 
    = CustomChannelFactory<IService>.CreateConfigurationChannel())
{
    channel.Open();

    //do stuff
}// channels disposes off??
like image 531
chugh97 Avatar asked Jan 30 '12 09:01

chugh97


2 Answers

That used to be the commonly accepted way to release WCF client proxies in the "early" days of WCF.

However things have since changed. It turned out that the implementation of IClientChannel<T>.Dispose() simply invokes the IClientChannel<T>.Close() method, which may throw an exception under some circumstances, such as when the underlying channel isn't open or can't be closed in a timely fashion.

Therefore it's not a good idea to invoke Close() within a catch block since that may leave behind some unreleased resources in case of an exception.

The new recommended way is to invoke IClientChannel<T>.Abort() within the catch block instead, in case Close() would fail. Here's an example:

try
{
    channel.DoSomething();
    channel.Close();
}
catch
{
    channel.Abort();
    throw;
}

Update:

Here's a reference to an MSDN article that describes this recommendation.

like image 83
Enrico Campidoglio Avatar answered Oct 30 '22 02:10

Enrico Campidoglio


Although not strictly directed at the channel, you can do:

ChannelFactory<IMyService> channelFactory = null;
try
{
    channelFactory =
        new ChannelFactory<IMyService>();
    channelFactory.Open();

    // Do work...

    channelFactory.Close();
}
catch (CommunicationException)
{
    if (channelFactory != null)
    {
        channelFactory.Abort();
    }
}
catch (TimeoutException)
{
    if (channelFactory != null)
    {
        channelFactory.Abort();
    }
}
catch (Exception)
{
    if (channelFactory != null)
    {
        channelFactory.Abort();
    }
    throw;
}
like image 34
tom redfern Avatar answered Oct 30 '22 03:10

tom redfern