Core data insert multiple objects

Question

Is that the right way to save multiple objects with relationships? Or is there a way to improve the code and save the context just one time? Thanks!!

for (NSDictionary *entries in dataArray){
    module = [NSEntityDescription insertNewObjectForEntityForName:@"Modules" inManagedObjectContext:context];
    module.m_id=[entries objectForKey:@"id"];
    module.m_name = [entries objectForKey:@"name"];
    module.m_timestamp = [NSDate date];

    //This line links the product by adding an entry to the NSSet of list for the module relation
    [product addModulesObject:module];

    //This line link the module with the product using product relation
    [module setProduct:product];

    NSError *error = nil;
    if (![context save:&error]) {
        NSLog(@"Unresolved error %@, %@", error, [error userInfo]);
        abort();
    }
}

Answer 1

You can move this code out of the loop.

NSError *error = nil;
if (![context save:&error]) {
     NSLog(@"Unresolved error %@, %@", error, [error userInfo]);
     abort();
}

Answer 2

Saving after every object is created could bring performance problems, so it's better to wait until all objects are created and save the context.

Just save the context after going trough the array:

for (NSDictionary *entries in dataArray){
    module = [NSEntityDescription insertNewObjectForEntityForName:@"Modules" inManagedObjectContext:context];
    module.m_id=[entries objectForKey:@"id"];
    module.m_name = [entries objectForKey:@"name"];
    module.m_timestamp = [NSDate date];

    //This line links the product by adding an entry to the NSSet of list for the module relation
    [product addModulesObject:module];

    //This line link the module with the product using product relation
    [module setProduct:product];
}
NSError *error = nil;
if (![context save:&error]) {
    NSLog(@"Unresolved error %@, %@", error, [error userInfo]);
    abort();
}