Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Cordova Exec blocked the main thread even after usage of CordovaInterface.getThreadPool()

I get following warning:

THREAD WARNING: exec()
 call to MyPlugin.setAndroidPreferences blocked the main thread for 49ms.   
Plugin should use CordovaInterface.getThreadPool().

But from my code I use cordova.getThreadPool():

private boolean setAndroidPreferences(
        final JSONArray args,
        final CallbackContext callbackContext)
{
    cordova.getThreadPool().execute(new Runnable() {
        @Override
        public void run() {
            try {
                /* ... */

                if ( /* ... */) 
                {
                    final SharedPreferences settings = cordova.getActivity().getSharedPreferences(preferenceLib, Context.MODE_PRIVATE);
                    final SharedPreferences.Editor editor = settings.edit();

                    editor.putString(preferenceName, preferenceValue);
                    editor.commit();
                    callbackContext.sendPluginResult(new PluginResult(PluginResult.Status.OK));                     
                } else {                                                callbackContext.sendPluginResult(new PluginResult(PluginResult.Status.ERROR));
                }
            } catch (JSONException e) {
                e.printStackTrace();
                Log.e(TAG, "getSetSharePreferences" + ": Error: " + PluginResult.Status.JSON_EXCEPTION);
                callbackContext.sendPluginResult(new PluginResult(PluginResult.Status.JSON_EXCEPTION));
            }
        }
    });
    return true;
}

What Im doing wrong?

Thanks,

like image 870
snaggs Avatar asked Jul 05 '14 15:07

snaggs


1 Answers

According to THREAD WARNING: exec() call blocked the main thread. Plugin should use CordovaInterface.getThreadPool(). – Cordova Plugin Warning, try the following:

    public boolean execute(String action, final JSONArray inputs, final CallbackContext callbackContext) throws JSONException {
        if (action.equals("setAndroidPreferences")) {
            cordova.getThreadPool().execute(new Runnable() {
                @Override
                public void run() {
                    callbackContext.sendPluginResult(setAndroidPreferences(inputs));
                }
            });
        }
    }

    private PluginResult setAndroidPreferences(JSONArray args) {
        try {
            if ( /* ... */) {
                SharedPreferences settings = cordova.getActivity().getSharedPreferences(preferenceLib, Context.MODE_PRIVATE);
                SharedPreferences.Editor editor = settings.edit();

                editor.putString(preferenceName, preferenceValue);
                editor.commit();
                return new PluginResult(PluginResult.Status.OK);                     
            } else {
                return new PluginResult(PluginResult.Status.ERROR);
            }
        } catch (JSONException e) {
            e.printStackTrace();
            Log.e(TAG, "getSetSharePreferences" + ": Error: " + PluginResult.Status.JSON_EXCEPTION);
            return new PluginResult(PluginResult.Status.JSON_EXCEPTION);
        }
    }
}
like image 127
Paul Facklam Avatar answered Oct 05 '22 06:10

Paul Facklam