Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Copy larger size variable unit16 to equivalent smaller array size unint8 by casting in c

Tags:

c

i2c

stm32

mcu

I have variable uint16_t value, I want to copy it to uint8_t buffer[3]. Is it possible to do (Little endian):

*buffer=*(uint8_t *)&value;

Instead of:

buffer[0] = highByte(value);
buffer[1] = lowByte(value);

Since this replacement cause stm32f7 I2C to not working correctly. Is there any correct casting?

like image 270
mohammadsdtmnd Avatar asked Jan 25 '23 04:01

mohammadsdtmnd


2 Answers

STM32 is little endian so you get the lowest significant byte first:

uint8_t* ptr = (uint8_t*)&value;
uint8_t low  = ptr[0];
uint8_t high = ptr[1];

Doing casts and de-referencing like this is fine for character types only. The above code is assuming that uint8_t is a character type, which is very likely the case (on gcc and other mainstream compilers).

For more info see What is CPU endianness?

EDIT:

If you simply wish to copy a 16 bit number into an array of bytes, the correct solution is this:

memcpy(buffer, &value, sizeof(uint16_t)).

We cannot do *(uint16_t*) buffer=value; because it invokes undefined behavior. buffer could be misaligned and it's also a strict aliasing violation. And this is why I wrote with emphasis above "this is fine for character types only".

like image 72
Lundin Avatar answered Feb 05 '23 04:02

Lundin


Is there any correct casting?

No

*buffer = <expression>

will always and only write to buffer[0] and never to buffer[1].

One thing you could do - but I strongly urge you NOT to is stuff like this:

uint16_t *ptr = (uint16_t*)buffer; // Ugh, danger
*ptr = value;

This will be problematic if you run it on machines with different endianess. And it's quite possible that there are other reasons to not do this too. As soon as you ask yourself if you can solve something via casting, you should really take a step back. Here are two answers I have written about that:

https://stackoverflow.com/a/62563330/6699433

https://stackoverflow.com/a/63773195/6699433

like image 30
klutt Avatar answered Feb 05 '23 03:02

klutt