Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

ConnectivityManager leaking, not sure how to resolve

So, I have this method that let's me know if the user has an active internet connection. It works well. However, leak canary has identified a memory leak associated with the connectivityManager. I am presently not closing the connectivityManager anywhere in my code at any time that I know of.

I've tried to close the connectivityManager in onDestroy. Either that isn't an option or I don't know the code. Truth be told, I simply tried to get auto fill to tell me how to do it. No luck.

public static boolean isNetworkAvailable(Context context) {
    ConnectivityManager connectivityManager =(ConnectivityManager)  context.getSystemService(Context.CONNECTIVITY_SERVICE);
    NetworkInfo activeNetworkInfo =connectivityManager.getActiveNetworkInfo();
    return activeNetworkInfo !=null && activeNetworkInfo.isConnected();
}
like image 406
seekingStillness Avatar asked Jan 02 '17 18:01

seekingStillness


2 Answers

Use this to prevent leak,

ConnectivityManager connectivityManager = (ConnectivityManager) context.getApplicationContext()
                .getSystemService(Context.CONNECTIVITY_SERVICE);
like image 107
santosh kumar Avatar answered Nov 17 '22 03:11

santosh kumar


Sharing a new answer as there is a catch:

I tried fixing the bug by instantiating ConnectivityManager using the following code in my activity:

ConnectivityManager connectivityManager = (ConnectivityManager) context.getApplicationContext()
            .getSystemService(Context.CONNECTIVITY_SERVICE);

However, this did not fix the memory leak. The problem is that even before my activity is called, some dependent library might be internally using ConnectivityManager in its code which leads to static variable of context being initialized to an activity context. The trick to fix this is to instantiate ConnectivityManager in the Application class just for the sake of it (unused).

public class MyApp extends Application {
    @Override
    public void onCreate() {
         ConnectivityManager cm = (ConnectivityManager) getApplicationContext().getSystemService(Context.CONNECTIVITY_SERVICE);
    }
}
like image 44
Adi Avatar answered Nov 17 '22 05:11

Adi