Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Code within d3.json() callback is not executed

I am trying to load a GeoJSON file and to draw some graphics using it as a basis with D3 v5.

The problem is that the browser is skipping over everything included inside the d3.json() call. I tried inserting breakpoints to test but the browser skips over them and I cannot figure out why.

Code snippet below.

d3.json("/trip_animate/tripData.geojson", function(data) {    console.log("It just works");  // This never logs to console.    //...all the rest } 

The code continues on from the initial console.log(), but I omitted all of it since I suspect the issue is with the d3.json call itself.

like image 836
camelCaseCowboy Avatar asked Apr 11 '18 06:04

camelCaseCowboy


1 Answers

The signature of d3.json has changed from D3 v4 to v5. It has been moved from the now deprecated module d3-request to the new d3-fetch module. As of v5 D3 uses the Fetch API in favor of the older XMLHttpRequest and has in turn adopted the use of Promises to handle those asynchronous requests.

The second argument to d3.json() no longer is the callback handling the request but an optional RequestInit object. d3.json() will now return a Promise you can handle in its .then() method.

Your code thus becomes:

d3.json("/trip_animate/tripData.geojson")   .then(function(data){     // Code from your callback goes here...   }); 

Error handling of the call has also changed with the introduction of the Fetch API. Versions prior to v5 used the first parameter of the callback passed to d3.json() to handle errors:

d3.json(url, function(error, data) {    if (error) throw error;   // Normal handling beyond this point. }); 

Since D3 v5 the promise returned by d3.json() will be rejected if an error is encountered. Hence, vanilla JS methods of handling those rejections can be applied:

  1. Pass a rejection handler as the second argument to .then(onFulfilled, onRejected).

  2. Use .catch(onRejected) to add a rejection handler to the promise.

Applying the second solution your code thus becomes

d3.json("/trip_animate/tripData.geojson")   .then(function(data) {     // Code from your callback goes here...   })   .catch(function(error) {     // Do some error handling.   }); 
like image 113
altocumulus Avatar answered Sep 19 '22 23:09

altocumulus