Menu
I need to do a code review of a whole branch in GitHub. I went to the branches page and hit compare. There's a tab there, files changed, that shows exactly what I need, the diff between the two branches, master and the selected one. The problem is that it doesn't allow you to comment on code like a single diff does:
The blue bubble just doesn't appear on the branch diff page.
Does anybody know how to perform a code review of a whole branch in GitHub?
Thanks.
704
I suggest to start with the branch name review/<review_subject> in order to easily distinguish it from regular branches. Push the branch. Create a new pull request on GitHub. Pull the branch that you want to be reviewed into the review branch.
Above the changed code, click Review changes. Type a comment summarizing your feedback on the proposed changes. Select Approve to approve merging the changes proposed in the pull request. Click Submit review.
Open a Pull Request – This is a formal request for your commit to be reviewed by another developer. Code Review – A developer agrees to perform a code review on your commit, which may be done formally or informally. If approved, your commit takes a step forward (to #5 or #6 depending on your team's process).
Apparently there's no UI to write comments on a branch diff. My solution for now was asking the other programmer to do a pull request. It did work to do a pull request from one project to itself and in the pull request I can write comments.
134
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With
