Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Class constructor cannot be invoked without 'new' - typescript with commonjs

I am making server side chat with colyseus (node game server framework). Im using typescript with module:commonjs because colyseus is built upon commonjs.

I have class ChatRoom that extends Colyseus.Room. At run-time I get this error:

Class constructor Room cannot be invoked without 'new'.

And the trouble in javascript:

function ChatRoom() {
   return _super !== null && _super.apply(this, arguments) || this;
}

from typescript class:

import {Room} from "colyseus";

export class ChatRoom extends Room {

    onInit(options) {
        console.log("BasicRoom created!", options);
    }

    onJoin(client) {
        this.broadcast(`${ client.sessionId } joined.`);
    }

    onLeave(client) {
        this.broadcast(`${ client.sessionId } left.`);
    }

    onMessage(client, data) {
        console.log("BasicRoom received message from", client.sessionId, ":", data);
        this.broadcast(`(${ client.sessionId }) ${ data.message }`);
    }

    onDispose() {
        console.log("Dispose BasicRoom");
    }
  }

The error is easily skipped when troubled row is removed after compilation. But the base class is not created and this is not a complete solution.

I googled the issue and it seems to relate to babel transpiler, though I don't use babel. I only use tsc / tsconfig.json.

like image 844
Александър К. Avatar asked May 06 '18 18:05

Александър К.


3 Answers

TypeScript transpiles a class to its ES5 counterpart, but this way it's necessary that entire class hierarchy is transpiled to ES5.

In case parent class is untranspiled (native class or imported ES6 class, including the ones that were transpiled with Babel), this won't work, because TypeScript relies on var instance = Parent.call(this, ...) || this trick to call parent constructor, while ES6 classes should be called only with new.

This problem should be solved in Node.js by setting TypeScript target option to es6 or higher. Modern Node.js versions support ES6 classes, there is no need to transpile them.

The same problem applies to Babel.

like image 88
Estus Flask Avatar answered Oct 10 '22 23:10

Estus Flask


For those who are using ts-node, it could be possible that your tsconfig.json is unable to be loaded by ts-node.

  1. Make sure you've set the below option for tsconfig.json:
{
    "compilerOptions": {
        "target": "ES6",
        ...
    }
}
  1. Try ts-node --script-mode or use --project to specify the path of your tsconfig.json.
like image 20
Devo Avatar answered Oct 11 '22 00:10

Devo


I came across the same problem using javascript, webpack, and babel (but no TypeScript).

I found a solution based on ES6/Babel Class constructor cannot be invoked without 'new'

I needed to explicitly include colyseus in my babel loader. Below is the snippet in my webpack config file:

  module: {
    rules: [
      {
        test: /\.js$/,
        exclude: /node_modules/,
        include: /colyseus/,
        use: {
          loader: "babel-loader"
        }
      }
    ]
  },
like image 4
oxer Avatar answered Oct 11 '22 00:10

oxer