Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Clang Warning on expression side effects

Tags:

Given the following source code:

#include <memory>
#include <typeinfo>

struct Base {
  virtual ~Base();
};

struct Derived : Base { };

int main() {
  std::unique_ptr<Base> ptr_foo = std::make_unique<Derived>();

  typeid(*ptr_foo).name();

  return 0;
}

and compiled it with:

clang++ -std=c++14 -Wall -Wextra -Werror -Wpedantic -g -o test test.cpp

Enviroment setup:

linux x86_64
clang version 5.0.0

It does not compile because of warning (note -Werror):

error: expression with side effects will be evaluated
      despite being used as an operand to 'typeid'
      [-Werror,-Wpotentially-evaluated-expression]
  typeid(*ptr_foo).name();

(Just a note: GCC does not claim that kind of potential problematic)


Question

Is there a way to get the information about the type pointed by a unique_ptr without generating that kind of warning?

Note: I am not talking about disabling -Wpotentially-evaluated-expression or avoiding -Werror.

like image 219
BiagioF Avatar asked Sep 29 '17 18:09

BiagioF


1 Answers

Looks like following should work without warnings and give correct result for derived class

std::unique_ptr<Foo> ptr_foo = std::make_unique<Bar>();

if(ptr_foo.get()){
    auto& r = *ptr_foo.get();
    std::cout << typeid(r).name() << '\n';
}
like image 83
Artemy Vysotsky Avatar answered Sep 17 '22 21:09

Artemy Vysotsky