Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Choose random integer in a range bigger than Integer.MAX_VALUE?

Tags:

java

random

I know there are another questions about random in a range but none of their answers accomplishes what I am trying to do. Actually they have the same error I have. I wrote this simple function to generate random with range.

Random m_random = new Random();
...
public int RandomWithRange(int min, int max) {
    return m_random.nextInt(max - min + 1) + min;
}

If range is bigger than Integer.MAX_VALUE, it throws an IllegalArgumentException: n must be positive. I know it overflows and turn to a negative number. My question is how to handle that?

Example ranges;

  • [0, Integer.MAX_VALUE]
  • [Integer.MIN_VALUE, Integer.MAX_VALUE]
  • [-100, Integer.MAX_VALUE]

Note: min and max must be inclusive.

like image 401
previous_developer Avatar asked Dec 15 '22 23:12

previous_developer


2 Answers

You cannot use int in this case. You need to go with BigInteger. The following constructor does what you want (need some tweaking for your needs of course):

BigInteger(int numBits, Random rnd) 

Constructs a randomly generated BigInteger, uniformly distributed over the range 0 to (2numBits - 1), inclusive.

like image 80
Hakan Serce Avatar answered Dec 22 '22 00:12

Hakan Serce


The problem you have is that (max - min) overflows and gives you a negative value.

You can use a long instead.

public int randomWithRange(int min, int max) {
    return (int) ((m_random.nextLong() & Long.MAX_VALUE) % (1L + max - min)) + min;
}
like image 39
Peter Lawrey Avatar answered Dec 21 '22 22:12

Peter Lawrey