can this trim code ever fail?

Question

I recently bumped into an exception in my code because I was trimming a null string. I replaced it with the following:

  SomeValue = (SomeString ?? "").Trim();

Can this code ever fail?

Thanks.

Note: I know I can add a try/catch; I'm just looking to make this line fail-proof without using a try/catch.

Answer 1

This will not fail (ie. throw a NullReferenceException), assuming SomeString is indeed a string.

You could achieve the same in many ways:

SomeValue = (SomeString == null)?string.Empty:SomeString.Trim();