Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Can I name a variable with the same name as a typedef'd structure name?

Tags:

c

gcc

Here is the structure declare code.

struct list_el {
    int val;
    struct list_el * next;
};

typedef struct list_el item;

And when I write a function like this, the compiler gives a error. It says cur undeclared before first use.

bool delete(item* item)
{
    assert(item != NULL);

    item* cur = NULL;
    cur = head;
    item* prev = NULL;
    while (cur) {
        if (cur == item) {
            if (prev == NULL) {
                head = item->next;
            } else {
                prev->next = item->next;
            }
            free(item);
            return true;
        }

        prev = cur;
        cur = cur->next;
    }
    return false;
}

After I look up the reference, it says the typedef works out just a bit like #define. It simply makes a substitution at compile time. Is that the reason the code can't be compiled?

like image 561
Frank Cheng Avatar asked Nov 14 '12 07:11

Frank Cheng


3 Answers

In this code:

bool delete(item* item)
{
    item *cur = NULL;

the item in the third line is taken to be the name of the variable item (the parameter to the function), and not the type. Consequently, the third line looks as if it starts out as an expression that multiplies item by the undefined variable cur, which leads to problems; the rest of the expression is also bogus.

If this isn't what you want, don't use the same name for a type and a variable. You'll confuse other people even if you don't confuse yourself and the compiler.


Whichever reference source said that typedef and #define are 'the same' should be dropped from your list of references now! If it can't differentiate two such fundamentally different constructs, it is dangerous because you won't know when it is misleading you (but this is one case where it is misleading you).

like image 122
Jonathan Leffler Avatar answered Oct 23 '22 07:10

Jonathan Leffler


A typedef is just a new name for an already existing type. defines are handled by the preprocessor while typedefs are handled by the C compiler itself. [copied from this link]

check this question: Are typedef and #define the same in c?

like image 22
MOHAMED Avatar answered Oct 23 '22 07:10

MOHAMED


typedef is not completely same as #define

Here is the difference by example:

#define cptr1 char*

typedef char* cptr2;

In code:

           int main()
            {
             cptr1 c1,c2; // first case : 
        // here c1 will be pointer to char but c2 is only char as cptr 
   // is directly replaced by char* by preprocessor
            cptr2 c3,c4; // second case :
      // here c3 and c4 both are pointers to char 
            }
like image 40
Omkant Avatar answered Oct 23 '22 07:10

Omkant