Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Cache == null? Is it possible?

Is it legal to make the following statement:

if(Cache[CACHE_KEY] == null)
{
    //do something to form cache
}
else
{
    //do something else that uses cache
}

I'm not sure my program is actually functioning properly (even though it compiles) and am wondering if a cache doesn't exist is it set to null?

like image 750
locoboy Avatar asked Apr 06 '11 08:04

locoboy


2 Answers

Yes, that is legal (but the question in the title is not, see below for details).

Though, it may be wise to check that the type in the cache is what you're expecting rather than having to do this check twice, such as:

//in English, the following line of code might read:
//    if the item known in the cache by the specified key is in
//    in fact of type MyExpectedReferenceType, then give me it 
//    as such otherwise, give me a null reference instead...
var myCachedInstance = Cache[key] as MyExpectedReferenceType;
if (myCachedInstance == null)
{  
    //we retrieved a reference to an instance of an MyExpectedReferenceType
}
else
{
    //oh, no - we didn't!
}

On re-reading your question though, and thinking about your program not working properly, I'm tempted to say you have bigger issues than this; how is your program not working correctly? The Cache instance itself will never be null while accessible - it is a read-only field of Page. However, your expected cached value could be null and, if this is the problem, you should be receiving a NullReferenceException - is that the case?

UPDATE:

To address your comment, check out the comments I added to the code.

like image 148
Grant Thomas Avatar answered Sep 22 '22 09:09

Grant Thomas


Very much legal; rather its better to check for a value before performing action, especially to make sure that key has not slided-out, or expired, etc.

like image 38
KMån Avatar answered Sep 24 '22 09:09

KMån