Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

C# Bug in Modulo Operator %

Tags:

c#

.net

math

modulo

Solving one bug I came to some interesting discoveries.

The result of this procedure

    static void Main(string[] args)
    {
        int i4 = 4;
        Console.WriteLine("int i4 = 4;");
        Console.WriteLine("i4 % 1 = {0}", i4 % 1);

        double d4 = 4.0;
        Console.WriteLine("double d4 = 4.0;");
        Console.WriteLine("d4 % 1 = {0}", d4 % 1);
        Console.WriteLine("-----------------------------------------------------------");
        int i64 = 64;
        double dCubeRootOf64 = Math.Pow(i64, 1.0 / 3.0);
        Console.WriteLine("int i64 = 64;");
        Console.WriteLine("double dCubeRootOf64 = Math.Pow(i64, 1.0 / 3.0) = {0}", dCubeRootOf64);
        Console.WriteLine("dCubeRootOf64 = {0}", dCubeRootOf64);
        Console.WriteLine("dCubeRootOf64 % 1 = {0} ??????????????  Why 1. ??????????", dCubeRootOf64 % 1);

        Console.ReadLine();
    }

is

int i4 = 4;
i4 % 1 = 0
double d4 = 4.0;
d4 % 1 = 0
-----------------------------------------------------------
int i64 = 64;
double dCubeRootOf64 = Math.Pow(i64, 1.0 / 3.0) = 4
dCubeRootOf64 = 4
dCubeRootOf64 % 1 = 1 ??????????????  Why 1. ??????????

int 4 % 1 = 0 -- correct

double 4.0 % 1 = 0 -- correct

But bug is in:

Math.Pow(64, 1.0 / 3.0) % 1 = 1

Cube root from 64 is 4. Why is in that case 4 % 1 = 1?

like image 726
SelvirK Avatar asked May 24 '12 19:05

SelvirK


People also ask

What C is used for?

C programming language is a machine-independent programming language that is mainly used to create many types of applications and operating systems such as Windows, and other complicated programs such as the Oracle database, Git, Python interpreter, and games and is considered a programming foundation in the process of ...

What is C in C language?

What is C? C is a general-purpose programming language created by Dennis Ritchie at the Bell Laboratories in 1972. It is a very popular language, despite being old. C is strongly associated with UNIX, as it was developed to write the UNIX operating system.

What is the full name of C?

In the real sense it has no meaning or full form. It was developed by Dennis Ritchie and Ken Thompson at AT&T bell Lab. First, they used to call it as B language then later they made some improvement into it and renamed it as C and its superscript as C++ which was invented by Dr.

Is C language easy?

Compared to other languages—like Java, PHP, or C#—C is a relatively simple language to learn for anyone just starting to learn computer programming because of its limited number of keywords.


2 Answers

Math.Pow(64, 1.0 / 3.0) returns 3.9999999999999996.
This gets rounded to 4 when displayed.

Taking it modulo 1 returns 0.99999999999999956, which is similarly rounded to 1 when displayed.

You can see the true values by adding .ToString("R")

like image 161
SLaks Avatar answered Sep 22 '22 07:09

SLaks


dCubeRootOf64 % 1 = 1 returns 1 instead 0; cause Math.Pow(i64, 1.0 / 3.0) returns 3.9999999999999996 and 3.9999999999999996 % 1 returns 0.99999999999999956 which in turn getting rounded to 1.

Thus the result 1.

like image 28
Rahul Avatar answered Sep 24 '22 07:09

Rahul