Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Boost's data-driven tests' join operator `+` corrupts first column

Consider the following code:

BOOST_DATA_TEST_CASE(
      sampleTest,
      (data::make(1) ^ data::make(2)) + (data::make(3) ^ data::make(4)),
      var1,
      var2)
{
  std::cout << var1 << "," << var2 << std::endl;
}

The output I expect is:

1,2
3,4

However, var1 appears to be corrupt:

$> ./MyTests --run_test=Tests/sampleTest
Running 2 test cases...
202875304,2
202875304,4

*** No errors detected
$> ./MyTests --run_test=Tests/sampleTest
Running 2 test cases...
83976616,2
83976616,4

*** No errors detected

Am I doing something wrong?

like image 485
Addy Avatar asked Jan 04 '18 19:01

Addy


1 Answers

That's a bug. Long story short: please report it to the library maintainers.

Indeed, the zip operation returns a tuple std::tuple<int const&, int const&>:

and though the dataset itself is properly alive at the time, the tuple is returned by reference in the join operation...:

    sample const&       operator*() const   { return m_first_size > 0 ? *m_it1 : *m_it2; }

The proper fix would be to extend the dataset concept to not only have a ::sample type¹ but also a ::reference type. That's quite an invasive change.


¹ strangely not documented at this time

like image 179
sehe Avatar answered Nov 16 '22 02:11

sehe